Compare DataFrames #1556
Open
Compare DataFrames #1556
+379
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es, there is no difference in the logic
Jolanrensen
reviewed
Nov 21, 2025
| import org.jetbrains.kotlinx.dataframe.api.emptyDataFrame | ||
| import org.jetbrains.kotlinx.dataframe.nrow | ||
|
|
||
| internal class ComparisonDescription( |
Collaborator
There was a problem hiding this comment.
data schemas are created with @DataSchema, not with : DataRowSchema
Contributor
Author
There was a problem hiding this comment.
Thank you for reviewing! I added @DataSchema , however with the current implementation : DataRowSchema
is still necessary because of lines 41-42..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES #658
It makes possible to compare DataFrame by exploiting Myers difference algotithm whose cost is O((M+N)*D) .
M is length of dfA, N is length of dfB, D is length of shortest edit script to get B from A.
Returns a DataFrame< ComparisonDescription >,
ComparisonDescription is a schema created specifically for this use case.
It comes with a proper test case.
About Myers difference algotithm:
https://neil.fraser.name/writing/diff/myers.pdf