Adding utils to help ensure that compile time schema ~ runtime schema #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koperagen
force-pushed
the
compile-time-schema
branch
from
b7ea13b to
e37b49e
Compare
zaleslaw
reviewed
Jul 5, 2024
...n-dataframe/tests/org/jetbrains/kotlin/fir/dataframe/AbstractDataFrameBlackBoxCodegenTest.kt
Outdated
Show resolved
Hide resolved
zaleslaw
reviewed
Jul 5, 2024
| data class Group(val id: String, val participants: List<Person>) : DataRowSchema | ||
|
|
||
| @Test | ||
| fun `deeply convert data schema and list of data schema`() { |
Collaborator
There was a problem hiding this comment.
Is it worth to compare here, for example, a circular references?
Group depends on Person, Person depends on Group
Collaborator
Author
There was a problem hiding this comment.
I started working on this PR with this circular reference idea in mind. Because regular Kotlin object can have them quite easily. But since we ended up converting only DataSchema objects deeply, i think it's not an issue anymore. You really need to do it on purpose to have a cycle between DataSchema objects. So i think it's not worth to bother here
zaleslaw
approved these changes
Jul 5, 2024
koperagen
force-pushed
the
compile-time-schema
branch
from
e37b49e to
d744ddc
Compare
Contributor
|
Generated sources will be updated after merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.