Handle InvocationTargetException exception explicitly in DokkaBootstrap
#4257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…strap` to show better error messages in DGPv2, as Gradle will not show the cause of `InvocationTargetException` without `--stacktrace` flag Fixes #4235
vmishenev
approved these changes
Sep 15, 2025
|
|
||
| class DokkaGeneratorFailureTest : FunSpec({ | ||
| context("DokkaGenerator failure:") { | ||
| val project = gradleKtsProjectTest("dokka-generator-failure") { |
Contributor
There was a problem hiding this comment.
Can you make this test more straightforward? Or even add one more with a custom exception/pre-generation check?
For example, if intersecting roots are allowed in the future, this case could be lost.
See the original test
Collaborator
Author
There was a problem hiding this comment.
Oh, nice idea!
I will add an additional test similar to the previous one.
It would still be nice to have a functional test for DGP, so that we really show the exception from checks or just failures here.
Member
|
post merge review: Looks good! I think the ServiceLoader implementation would also help with error handling #4216 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle
InvocationTargetExceptionexception explicitly inDokkaBootstrapto show better error messages in DGPv2, as Gradle will not show the cause ofInvocationTargetExceptionwithout--stacktraceflagFixes #4235