Fix classpath when source set has no metadata compilations #4296
+2,298
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-enko
added
the
runner: Gradle plugin
adam-enko
changed the base branch from
master
to
adam/support-agp-kotlin-builtin
Collaborator
|
JIC: my attempt to fix |
adam-enko
force-pushed
the
adam/support-agp-kotlin-builtin
branch
from
12c2bb1 to
4dd9e43
Compare
adam-enko
force-pushed
the
adam/fix-classpath-without-metadata-compilations
branch
from
4cddab4 to
685f09b
Compare
adam-enko
force-pushed
the
adam/support-agp-kotlin-builtin
branch
from
d2b6dd7 to
747573f
Compare
adam-enko
force-pushed
the
adam/fix-classpath-without-metadata-compilations
branch
from
685f09b to
62d4bff
Compare
Workaround for intermediate source sets missing dependencies (whether stdlib or user-defined). KT-80551
…actual' declarations
DGP can still produce output even when the code cannot be compiled. To avoid creating invalid examples, add a test.
adam-enko
force-pushed
the
adam/fix-classpath-without-metadata-compilations
branch
from
d249aa3 to
ab74561
Compare
adam-enko
changed the base branch from
adam/support-agp-kotlin-builtin
to
master
adam-enko
commented
Nov 24, 2025
Member
Author
There was a problem hiding this comment.
The main change of this PR is in KotlinAdapter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an intermediate KotlinSourceSet has no metadata compilation (e.g. webMain, mingwMain), the classpath misses the required dependencies (e.g. kotlin-stdlib, or those defined in buildscripts).
This PR updates the logic for determining the classpath. If a source set has no primary compilations, and it has no metadata compilations, then the classpath should be aggregated from the 'leaf' source sets.
Additionally, update kotlin-multiplatform-example to compile(!), and test webMain.
Workaround for: