Use toolchains for java tasks #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qurbonzoda
suggested changes
Feb 5, 2024
There was a problem hiding this comment.
It would be nice if a guide was provided on how to specify toolchains for JVM benchmarks, considering the fact that it doesn’t seem to be easy to infer the use of org.gradle.toolchains.foojay-resolver-convention plugin.
It can be added to #182 later though.
integration/src/test/resources/templates/kmp-with-toolchain/build.gradle
Show resolved
Hide resolved
|
Please squash the fixup commits before merging. |
qurbonzoda
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle tasks configured to run JVM benchmarks didn't use the project's Java toolchain and instead used the same Java executables as the Gradle did. That could lead to a scenario when the project had a Java toolchain with a higher version than the version of Java Gradle was launched with. In such a scenario benchmark compilation would fail.
This PR brings toolchain awareness to related Gradle tasks.
Fixes #176