Remove the incorrect default parameter in LocalTime.atDate #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From 0.4.0 (dc5c965), we have `LocalTime.atDate` with the default value `0` for `dayOfMonth: Int`. This doesn't make any sense, though, as `0` is not a valid day, so `LocalTime(23, 59).atDate(2025, 3)` just fails. This commit removes the default value. Since it was impossible to call `atDate` without specifying the day and not fail, no valid code should stop compiling.
ilya-g
reviewed
Mar 19, 2025
ilya-g
approved these changes
Mar 20, 2025
dkhalanskyjb
added a commit
that referenced
this pull request
Mar 20, 2025
From 0.4.0 (dc5c965), we have `LocalTime.atDate` with the default value `0` for `dayOfMonth: Int`. This doesn't make any sense, though, as `0` is not a valid day, so `LocalTime(23, 59).atDate(2025, 3)` just fails. This commit removes the default value. Since it was impossible to call `atDate` without specifying the day and not fail, no valid code should stop compiling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From 0.4.0 on (dc5c965), we have
LocalTime.atDatewith the default value0fordayOfMonth: Int. This doesn't make any sense, though, as0is not a valid day, soLocalTime(23, 59).atDate(2025, 3)just fails. This commit removes the default value. Since it was impossible to callatDatewithout specifying the day and not fail, no valid code should stop compiling.