Fix a dependency on kotlinx.serialization.core in JPMS for it to be truly optional #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhalanskyjb
changed the title
There are too many of them at this point to keep them in the root.
dkhalanskyjb
force-pushed
the
fix-incorrect-module-info
branch
from
df75736 to
1632f50
Compare
ilya-g
approved these changes
May 28, 2025
| kotlin("jvm") | ||
| } | ||
|
|
||
| java { |
There was a problem hiding this comment.
AFAIK, it was required to enable java.modularity.inferModulePath to put compilation dependencies on the module path instead of class path.
There was a problem hiding this comment.
Seems like it: https://docs.gradle.org/current/userguide/java_library_plugin.html#sec:java_library_modular
Gradle will automatically put a Jar of your dependencies on the module path, instead of the classpath, if these three things are true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #496