Skip to content

Serialization decoupling #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 16, 2025
Merged

Serialization decoupling #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4126e09
KRPC-165 kotlinx.serialization decoupling in compiler plugin
Mr3zee Jun 13, 2025
9839e77
apiDump
Mr3zee Jun 13, 2025
daf9e25
Update compiler tests
Mr3zee Jun 13, 2025
9218007
Fix all compiler versions
Mr3zee Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...er-plugin/compiler-plugin-backend/src/main/core/kotlinx/rpc/codegen/VersionSpecificApi.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ import org.jetbrains.kotlin.descriptors.SourceElement
import org.jetbrains.kotlin.ir.builders.declarations.IrFieldBuilder
import org.jetbrains.kotlin.ir.declarations.*
import org.jetbrains.kotlin.ir.expressions.IrCall
import org.jetbrains.kotlin.ir.expressions.IrConstructorCall
import org.jetbrains.kotlin.ir.expressions.IrExpression
import org.jetbrains.kotlin.ir.expressions.IrMemberAccessExpression
import org.jetbrains.kotlin.ir.expressions.IrStatementOrigin
import org.jetbrains.kotlin.ir.expressions.impl.IrCallImpl
Expand Down Expand Up @@ -53,6 +55,12 @@ interface VersionSpecificApi {

var IrConstructor.isPrimaryVS: Boolean

val IrConstructor.parametersVS: List<IrValueParameter>

val IrConstructorCall.argumentsVS: List<IrExpression?>

fun IrType.isNullableVS(): Boolean

val messageCollectorKey: CompilerConfigurationKey<MessageCollector>

companion object {
Expand Down
61 changes: 51 additions & 10 deletions ...lugin/compiler-plugin-backend/src/main/core/kotlinx/rpc/codegen/extension/RpcIrContext.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import org.jetbrains.kotlin.ir.symbols.IrClassSymbol
import org.jetbrains.kotlin.ir.symbols.IrPropertySymbol
import org.jetbrains.kotlin.ir.symbols.IrSimpleFunctionSymbol
import org.jetbrains.kotlin.ir.types.makeNullable
import org.jetbrains.kotlin.ir.types.typeWith
import org.jetbrains.kotlin.ir.util.functions
import org.jetbrains.kotlin.ir.util.isVararg
import org.jetbrains.kotlin.ir.util.nestedClasses
Expand All @@ -32,6 +33,14 @@ internal class RpcIrContext(
irBuiltIns.arrayClass.typeWith(anyNullable, Variance.OUT_VARIANCE)
}

val listOfAnnotations by lazy {
irBuiltIns.listClass.typeWith(irBuiltIns.annotationType)
}

val arrayOfAnnotations by lazy {
irBuiltIns.arrayClass.typeWith(irBuiltIns.annotationType, Variance.OUT_VARIANCE)
}

val kTypeClass by lazy {
getIrClassSymbol("kotlin.reflect", "KType")
}
Expand Down Expand Up @@ -68,10 +77,22 @@ internal class RpcIrContext(
getRpcIrClassSymbol("RpcType", "descriptor")
}

val rpcTypeDefault by lazy {
getRpcIrClassSymbol("RpcTypeDefault", "descriptor")
}

val rpcTypeKrpc by lazy {
getRpcIrClassSymbol("RpcTypeKrpc", "descriptor")
}

val rpcCallable by lazy {
getRpcIrClassSymbol("RpcCallable", "descriptor")
}

val rpcCallableDefault by lazy {
getRpcIrClassSymbol("RpcCallableDefault", "descriptor")
}

private val rpcInvokator by lazy {
getRpcIrClassSymbol("RpcInvokator", "descriptor")
}
Expand All @@ -84,8 +105,20 @@ internal class RpcIrContext(
getRpcIrClassSymbol("RpcParameter", "descriptor")
}

val rpcMethodClass by lazy {
getRpcIrClassSymbol("RpcMethodClass", "internal")
val rpcParameterDefault by lazy {
getRpcIrClassSymbol("RpcParameterDefault", "descriptor")
}

val kSerializer by lazy {
getIrClassSymbol("kotlinx.serialization", "KSerializer")
}

val kSerializerAnyNullable by lazy {
kSerializer.typeWith(anyNullable)
}

val kSerializerAnyNullableKClass by lazy {
irBuiltIns.kClassClass.typeWith(kSerializerAnyNullable)
}

fun isJsTarget(): Boolean {
Expand All @@ -103,10 +136,6 @@ internal class RpcIrContext(
val functions = Functions()

inner class Functions {
val dataCast by lazy {
namedFunction("kotlinx.rpc.internal", "rpcInternalDataCast")
}

val rpcClientCall by lazy {
rpcClient.namedFunction("call")
}
Expand All @@ -115,10 +144,6 @@ internal class RpcIrContext(
rpcClient.namedFunction("callServerStreaming")
}

val asArray by lazy {
rpcMethodClass.namedFunction("asArray")
}

val typeOf by lazy {
namedFunction("kotlin.reflect", "typeOf")
}
Expand All @@ -135,10 +160,26 @@ internal class RpcIrContext(
}
}

val emptyList by lazy {
namedFunction("kotlin.collections", "emptyList")
}

val listOf by lazy {
namedFunction("kotlin.collections", "listOf") {
vsApi {
it.owner.valueParametersVS().singleOrNull()?.isVararg ?: false
}
}
}

val mapGet by lazy {
irBuiltIns.mapClass.namedFunction("get")
}

val arrayGet by lazy {
irBuiltIns.arrayClass.namedFunction("get")
}

val emptyMap by lazy {
namedFunction("kotlin.collections", "emptyMap")
}
Expand Down
Loading