-
Notifications
You must be signed in to change notification settings - Fork 42
Kmp Source Sets for gRPC #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5l
approved these changes
Jul 23, 2025
| return property | ||
| } | ||
|
|
||
| // TODO change to commonMain/commonTest in docs when it's supported |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add link to an issue
Jozott00
approved these changes
Jul 23, 2025
Mr3zee
added a commit
that referenced
this pull request
Jul 24, 2025
Mr3zee
added a commit
that referenced
this pull request
Aug 1, 2025
Mr3zee
added a commit
that referenced
this pull request
Aug 8, 2025
Mr3zee
added a commit
that referenced
this pull request
Aug 21, 2025
Mr3zee
added a commit
that referenced
this pull request
Oct 27, 2025
Mr3zee
added a commit
that referenced
this pull request
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Gradle Plugin
Problem Description
Current solution uses
com.google.protobufplugin.It is limiting in different ways:
Options:
protocbinarybuilf.bufGradle pluginProviderAPISolution
Blend of Buf's great capabilities to manage proto files and our Gradle plugin to manage Buf.
We use Buf's executable but we configure its workspace using our Gradle tasks:
src/main/protoandsrc/test/protodirectory setssrc/jvmMain/protoandsrc/jvmTest/protodirectory setssrc/commonMain/protoandsrc/commonTest/protodirectory sets laternativeMain,jsMain, etc)protoSourceSetsextensionprotoSourceSets.jvmTest { proto.exclude("exclude/**") }protoSourceSets.jvmTest { protocPlugin(rpc.grpc.protocPlugins.kxrpc) }buf.yamlandbuf.gen.yamlfilesbuf.yamldefines modules:protofor files to be used for generation (in bothmainandtestsets)importfor files used as imported (resolvable but not used for generation) - used intestsets to import proto files frommainbuf.gen.yamldefines plugins:rpc.grpc.protocPluginscontainer.kxrpc,protobufJava,grpcJavaandgrpcKotlinProtocPluginclassjavasource setsrpc.grpc.protocPluginscontainer.generateBufYaml<sourceSet>- generatesbuf.yamlgenerateBufGenYaml<sourceSet>- generatesbuf.gen.yamlprocessProtoFiles<sourceSet>- copies proto files to the workspace directorybufGenerate<sourceSet>- runsbuf generatecommandbuftasks can be customised usingrpc.grpc.bufextension.buf generatetask can be customised usingrpc.grpc.buf.generateextension.buf generatetask is supported out-of-the-boxregisterBufExecTaskrpc.grpc.buf.tasks.registerWorkspaceTasklintwithout explicit support from us--debugoptionjava.homeor a user specified java executableNext steps
Comming in next PRs in no particular order and with no particular deadlines: