gRPC/Native: Add Wire Format encoder and decoder #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jozott00
changed the title
Mr3zee
requested changes
Jul 28, 2025
grpc/grpc-core/src/nativeMain/kotlin/kotlinx/rpc/grpc/internal/WireDecoder.native.kt
Show resolved
Hide resolved
grpc/grpc-core/src/nativeMain/kotlin/kotlinx/rpc/grpc/internal/WireDecoder.native.kt
Outdated
Show resolved
Hide resolved
grpc/grpc-core/src/nativeMain/kotlin/kotlinx/rpc/grpc/internal/WireEncoder.native.kt
Show resolved
Hide resolved
grpc/grpc-core/src/nativeMain/kotlin/kotlinx/rpc/grpc/internal/WireEncoder.native.kt
Outdated
Show resolved
Hide resolved
grpc/grpc-core/src/nativeMain/kotlin/kotlinx/rpc/grpc/internal/WireEncoder.native.kt
Show resolved
Hide resolved
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
…er and decoder with buffers Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
…tring to std::string Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Mr3zee
approved these changes
Jul 29, 2025
Mr3zee
added a commit
that referenced
this pull request
Jul 30, 2025
Co-authored-by: Alexander Sysoev <[email protected]>
Mr3zee
added a commit
that referenced
this pull request
Aug 1, 2025
Co-authored-by: Alexander Sysoev <[email protected]>
Mr3zee
added a commit
that referenced
this pull request
Aug 4, 2025
Co-authored-by: Alexander Sysoev <[email protected]>
Mr3zee
added a commit
that referenced
this pull request
Aug 8, 2025
Co-authored-by: Alexander Sysoev <[email protected]>
Mr3zee
added a commit
that referenced
this pull request
Aug 21, 2025
Co-authored-by: Alexander Sysoev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
gRPC/Native
Problem Description
One part of the gRPC implementation is the Protobuf wire format encoding and decoding.
This PR adds support for all values (except for sub-messages) to encode them into a
kotlinx.io.Bufferand decode a buffer back to Kotlin values.Solution
This PR adds two new main interfaces to the
commonMain:WireEncoderandWireDecode.Both interfaces must be implemented platform specifically. This PR provides implementations for the Kotlin Native platform.
Most of the encoding and decoding is done by the Protobuf C++ library, which is called using C-Interop. To avoid unnecessary data copying during decoding, the C++ decoder is directly bridged to the
ZeroCopyInputSourcethat provides low-level access to thekotlinx.io.Buffer. The implementation of theZeroCopyInputSourcehighly relies on the implementation ofkotlinx.io.Buffer.