-
Notifications
You must be signed in to change notification settings - Fork 40
gRPC: Support initial proto generation for common (JVM and Native) #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
…ove common proto generation to commonTest Signed-off-by: Johannes Zottele <[email protected]>
Mr3zee
approved these changes
Jul 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with minor comments
Please also run updateLegasyApi
to check that nothing has leaked into the public view
gradle-plugin/src/main/kotlin/kotlinx/rpc/proto/DefaultProtoSourceSet.kt
Show resolved
Hide resolved
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Mr3zee
pushed a commit
that referenced
this pull request
Aug 1, 2025
) * grpc-native: First message generation Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Support for repeated fields in Message generation Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Remove guards in generated kotlin Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Move internal decode/encoding into grpc.pb package and move common proto generation to commonTest Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Address PR comments Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Rename ProtosTest class Signed-off-by: Johannes Zottele <[email protected]> --------- Signed-off-by: Johannes Zottele <[email protected]>
Mr3zee
pushed a commit
that referenced
this pull request
Aug 4, 2025
) * grpc-native: First message generation Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Support for repeated fields in Message generation Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Remove guards in generated kotlin Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Move internal decode/encoding into grpc.pb package and move common proto generation to commonTest Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Address PR comments Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Rename ProtosTest class Signed-off-by: Johannes Zottele <[email protected]> --------- Signed-off-by: Johannes Zottele <[email protected]>
Mr3zee
pushed a commit
that referenced
this pull request
Aug 8, 2025
) * grpc-native: First message generation Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Support for repeated fields in Message generation Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Remove guards in generated kotlin Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Move internal decode/encoding into grpc.pb package and move common proto generation to commonTest Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Address PR comments Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Rename ProtosTest class Signed-off-by: Johannes Zottele <[email protected]> --------- Signed-off-by: Johannes Zottele <[email protected]>
Mr3zee
pushed a commit
that referenced
this pull request
Aug 21, 2025
) * grpc-native: First message generation Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Support for repeated fields in Message generation Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Remove guards in generated kotlin Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Move internal decode/encoding into grpc.pb package and move common proto generation to commonTest Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Address PR comments Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Rename ProtosTest class Signed-off-by: Johannes Zottele <[email protected]> --------- Signed-off-by: Johannes Zottele <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
gRPC/Common - Protobuf
Problem Description
The Kotlin source code generation for KMP common was missing.
Solution
This PR adds initial generation support for messages with primitive fields and primitive repeated fields.
This also adds a temporary option to the protoc plugin to distinguish between JVM and KMP common generation. This is required, as the current JVM implementation uses the same plugin.