grpc-common: Add field presence tracking, required field enforcing and generation of the MessageCodec implementation #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
…f all fields. Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
…sses Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Mr3zee
approved these changes
Aug 4, 2025
grpc/grpc-core/src/commonMain/kotlin/kotlinx/rpc/grpc/pb/InternalMessage.kt
Outdated
Show resolved
Hide resolved
grpc/grpc-core/src/commonMain/kotlin/kotlinx/rpc/grpc/utils/BitSet.kt
Outdated
Show resolved
Hide resolved
protoc-gen/src/main/kotlin/kotlinx/rpc/protobuf/ModelToKotlinCommonGenerator.kt
Show resolved
Hide resolved
protoc-gen/src/main/kotlin/kotlinx/rpc/protobuf/ModelToKotlinCommonGenerator.kt
Outdated
Show resolved
Hide resolved
protoc-gen/src/main/kotlin/kotlinx/rpc/protobuf/ModelToKotlinCommonGenerator.kt
Outdated
Show resolved
Hide resolved
protoc-gen/src/main/kotlin/kotlinx/rpc/protobuf/ModelToKotlinCommonGenerator.kt
Show resolved
Hide resolved
Signed-off-by: Johannes Zottele <[email protected]>
Mr3zee
pushed a commit
that referenced
this pull request
Aug 4, 2025
…d generation of the MessageCodec implementation (#421) * grpc-pb: Refactor subtyping hierarchy Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Add presence tracking and required field check Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Add PresenceIndices object that holds the presence indices of all fields. Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Move BitSet to utils Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Add MessageCodec object for each message Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Use only fully qualified names for kotlinx.rpc.grpc.pb.* classes Signed-off-by: Johannes Zottele <[email protected]> * Revert kotlin version increase Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Remove demo test Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Address PR comments Signed-off-by: Johannes Zottele <[email protected]> --------- Signed-off-by: Johannes Zottele <[email protected]>
Mr3zee
pushed a commit
that referenced
this pull request
Aug 8, 2025
…d generation of the MessageCodec implementation (#421) * grpc-pb: Refactor subtyping hierarchy Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Add presence tracking and required field check Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Add PresenceIndices object that holds the presence indices of all fields. Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Move BitSet to utils Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Add MessageCodec object for each message Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Use only fully qualified names for kotlinx.rpc.grpc.pb.* classes Signed-off-by: Johannes Zottele <[email protected]> * Revert kotlin version increase Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Remove demo test Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Address PR comments Signed-off-by: Johannes Zottele <[email protected]> --------- Signed-off-by: Johannes Zottele <[email protected]>
Mr3zee
pushed a commit
that referenced
this pull request
Aug 21, 2025
…d generation of the MessageCodec implementation (#421) * grpc-pb: Refactor subtyping hierarchy Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Add presence tracking and required field check Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Add PresenceIndices object that holds the presence indices of all fields. Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Move BitSet to utils Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Add MessageCodec object for each message Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Use only fully qualified names for kotlinx.rpc.grpc.pb.* classes Signed-off-by: Johannes Zottele <[email protected]> * Revert kotlin version increase Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Remove demo test Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Address PR comments Signed-off-by: Johannes Zottele <[email protected]> --------- Signed-off-by: Johannes Zottele <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
gRPC/Common - Protobuf
Description
This PR adds presence tracking for fields with explicit presence on the wire.
It does this by adding a
presenceMaskto each message, implemented asBitSet. The presence of each field that has explicit presence is represented by a bit in the mask.If a required field (
requiredfield in proto2 or a field annotated with[ LEGACY_REQUIRED ]in editions) is not present after construction, an error is thrown.This is done for both, user constructed messages (e.i. by the generated
invokefunction) and messages that were decoded from the wire using the message's decode function.Additionally, the PR adds generation of an implementation of the
MessageCodecinterface, used by the gRPC implementation to encode and decode messages. It is made available as object in the companion object of the generated internal message. E.g.MyMessageInternal.CODEC