Skip to content

Fix LV and signing #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025
Merged

Fix LV and signing #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions gradle-conventions/src/main/kotlin/conventions-publishing.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,12 @@ fun PublishingExtension.configurePublication() {
fixModuleMetadata(project)
}

// no way around this: https://github.com/gradle/gradle/issues/26091
val signingTasks = tasks.withType<Sign>()
tasks.withType<PublishToMavenRepository>().configureEach {
dependsOn(signingTasks)
}

logger.info("Project ${project.name} -> Publication configured: $name, $version")
}
}
Expand Down
12 changes: 12 additions & 0 deletions krpc/krpc-test/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@
*/

import org.jetbrains.kotlin.gradle.dsl.ExplicitApiMode
import org.jetbrains.kotlin.gradle.dsl.KotlinVersion
import org.jetbrains.kotlin.gradle.targets.js.testing.KotlinJsTest
import org.jetbrains.kotlin.gradle.targets.jvm.tasks.KotlinJvmTest
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
import java.nio.file.Files

plugins {
Expand All @@ -14,6 +16,16 @@ plugins {
alias(libs.plugins.atomicfu)
}

tasks.withType<KotlinCompile> {
if (this.name.contains("Test")) {
compilerOptions {
// for kotlin.time.Clock API
languageVersion.set(KotlinVersion.KOTLIN_2_1)
apiVersion.set(KotlinVersion.KOTLIN_2_1)
}
}
}

kotlin {
sourceSets {
commonMain {
Expand Down
6 changes: 3 additions & 3 deletions krpc/krpc-test/src/commonMain/kotlin/kotlinx/rpc/krpc/test/KrpcTransportTestBase.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,13 +305,13 @@ abstract class KrpcTransportTestBase {
}

@Test
fun `RPC should be able to receive 100_000 ints in reasonable time`() = runTest(timeout = JS_EXTENDED_TIMEOUT) {
fun RPC_should_be_able_to_receive_100_000_ints_in_reasonable_time() = runTest(timeout = JS_EXTENDED_TIMEOUT) {
val n = 100_000
assertEquals(client.getNInts(n).last(), n)
}

@Test
fun `RPC should be able to receive 100_000 ints with batching in reasonable time`() = runTest {
fun RPC_should_be_able_to_receive_100_000_ints_with_batching_in_reasonable_time() = runTest {
val n = 100_000
assertEquals(client.getNIntsBatched(n).last().last(), n)
}
Expand Down Expand Up @@ -405,7 +405,7 @@ abstract class KrpcTransportTestBase {
}

@Test
fun `rpc continuation is called in the correct scope and doesn't block other rpcs`() = runTest {
fun rpc_continuation_is_called_in_the_correct_scope_and_doesnt_block_other_rpcs() = runTest {
if (isJs) {
println("Test is skipped on JS, because it doesn't support multiple threads.")
return@runTest
Expand Down