Fix gRPC services tests #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oooooooh I think I know now, but it is cursed |
|
Is it because the |
Jozott00
reviewed
Aug 5, 2025
grpc/grpc-core/src/commonMain/kotlin/kotlinx/rpc/grpc/internal/suspendClientCalls.kt
Show resolved
Hide resolved
Jozott00
approved these changes
Aug 5, 2025
|
@Jozott00 yes, I thought each .request invokation changed the ready state but it is not |
Mr3zee
added a commit
that referenced
this pull request
Aug 8, 2025
Mr3zee
added a commit
that referenced
this pull request
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
gRPC
Problem Description
Tests with streaming were not working
Solution
Closer rewrite the code and see that
Readyhas one more property for overall client/server readinessDisclaimer: I have absolutely no idea why this fix works