Added gRPC service generation to the compiler plugin #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5l
approved these changes
Aug 6, 2025
|
|
||
| public fun <R> callServerStreaming(rpcCall: RpcCall): Flow<R> | ||
| } | ||
| //@ExperimentalRpcApi |
| value = value, | ||
| ) | ||
|
|
||
| private fun IrType.unwrapFlow(): IrType { |
There was a problem hiding this comment.
The class is huge. Please check what can be extracted as utility methods
There was a problem hiding this comment.
I still think that one big file is better DX, for the current size at least.
And while I'm the only person making bug changes here, I'd like to have like this. I have in mind splitting it, but only when it's size becomes an issue during the development
Jozott00
approved these changes
Aug 6, 2025
Jozott00
pushed a commit
that referenced
this pull request
Aug 7, 2025
Mr3zee
added a commit
that referenced
this pull request
Aug 8, 2025
Mr3zee
added a commit
that referenced
this pull request
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Compiler Plugin, gRPC
Problem Description
We have all platform bindings for the gRPC, but no service generation
Solution
Add service generations and a
MessageCodeclocator:MessageCodecResolverinGrpcClient/GrpcServerWithCodecannotation (default for protobuf messages)And we now have fully working gRPC services with arbitrary serilization.
For next PRs: