grpc-pb: Support maps #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Zottele <[email protected]>
Mr3zee
approved these changes
Aug 7, 2025
grpc/grpc-core/src/commonTest/kotlin/kotlinx/rpc/grpc/pb/ProtosTest.kt
Outdated
Show resolved
Hide resolved
protoc-gen/src/main/kotlin/kotlinx/rpc/protobuf/ModelToKotlinCommonGenerator.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Johannes Zottele <[email protected]>
Mr3zee
pushed a commit
that referenced
this pull request
Aug 8, 2025
Mr3zee
pushed a commit
that referenced
this pull request
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
gRPC/Protobuf
Solution
This PR adds support for maps in protobuf messages.
While the user interacts only with Kotlin
Maps, internally a entry message class in generated that contains the logic for encoding and decoding map entries. This is because a map is nothing but arepeatedfield of map entries, where a entry looks like