grpc-pb: Add gRPC Exceptions and skip unknown fields #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr3zee
approved these changes
Aug 8, 2025
grpc/grpc-core/src/commonMain/kotlin/kotlinx/rpc/grpc/pb/KTag.kt
Outdated
Show resolved
Hide resolved
grpc/grpc-core/src/commonMain/kotlin/kotlinx/rpc/grpc/pb/KTag.kt
Outdated
Show resolved
Hide resolved
grpc/grpc-core/src/commonMain/kotlin/kotlinx/rpc/grpc/pb/WireDecoder.kt
Outdated
Show resolved
Hide resolved
grpc/grpc-core/src/commonMain/kotlin/kotlinx/rpc/grpc/GrpcException.kt
Outdated
Show resolved
Hide resolved
Jozott00
force-pushed
the
grpc/pb-error
branch
2 times, most recently
from
111f0f8 to
d604bd2
Compare
Mr3zee
approved these changes
Aug 8, 2025
grpc/grpc-core/src/nativeMain/kotlin/kotlinx/rpc/grpc/pb/WireDecoder.native.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Jozott00
force-pushed
the
grpc/pb-error
branch
from
d8c8a36 to
a862992
Compare
Mr3zee
pushed a commit
that referenced
this pull request
Aug 21, 2025
* grpc-pb: Skip unknown fields Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Add InvalidProtobufError class Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Throw error in decoder instead of hadError() check Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Fix string encoding bug Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Remove hadError() method Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Throw exception instead of Boolean when encoding value Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Move JVM exception check to CODEC to avoid performance overhead Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Address PR comments Signed-off-by: Johannes Zottele <[email protected]> * grpc-pb: Address PR Comments Signed-off-by: Johannes Zottele <[email protected]> --------- Signed-off-by: Johannes Zottele <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
gRPC/Protobuf
Solution
This PR adds the
GrpcExceptionas well its sealed sub typesProtobufEncodingExceptionandProtobufDecodingException.Additionally, unknown fields are now skipped without an error.
There was also a bug in the native
WireEncoderthat caused the string length to include the null termination character, resulting in an invalid protobuf wire encoding of the message.