Skip to content

Conversation

Mr3zee
Copy link
Member

@Mr3zee Mr3zee commented Aug 11, 2025

Subsystem
gRPC, Protoc-gen

Problem Description
We initially merged gRPC and protobuf declarations, however, they are not coupled

Solution
Extract protobuf into a separate module and split protoc-gen into two

@Mr3zee Mr3zee requested a review from Jozott00 August 11, 2025 17:48
@Mr3zee Mr3zee self-assigned this Aug 11, 2025
@Mr3zee Mr3zee added the housekeeping Some miscellaneous code base changes, tests, etc. label Aug 11, 2025
@Mr3zee Mr3zee force-pushed the grpc-protobuf-split branch from 84a99b2 to f63ea14 Compare August 11, 2025 18:24
@Mr3zee
Copy link
Member Author

Mr3zee commented Aug 11, 2025

@Jozott00 for some reason I get

Exception in thread "main" java.lang.Error: /Users/Alexander.Sysoev/Desktop/AlexFolder/JetBrains/kotlinx-rpc/cinterop-c/include/grpcpp_c.h:9:10: fatal error: 'grpc/slice.h' file not found

Do you how to deal with it?

@Mr3zee Mr3zee force-pushed the grpc-protobuf-split branch from f63ea14 to b1d7d1c Compare August 11, 2025 18:37
@Mr3zee
Copy link
Member Author

Mr3zee commented Aug 11, 2025

It is also nor resolved when I open in CLion
image

@Mr3zee Mr3zee force-pushed the grpc-protobuf-split branch from b1d7d1c to a214820 Compare August 12, 2025 08:43
Copy link
Collaborator

@Jozott00 Jozott00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the separation!

@Mr3zee Mr3zee force-pushed the grpc-protobuf-split branch from a214820 to c425739 Compare August 12, 2025 09:36
@Mr3zee Mr3zee merged commit 43f48b4 into grpc-common Aug 12, 2025
2 of 3 checks passed
@Mr3zee Mr3zee deleted the grpc-protobuf-split branch August 12, 2025 09:37
Mr3zee added a commit that referenced this pull request Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

housekeeping Some miscellaneous code base changes, tests, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants