Skip to content

Set up protobuf conformance tests #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: grpc-common
Choose a base branch
from
Open

Set up protobuf conformance tests #447

wants to merge 5 commits into from
+17,418 −310

Conversation

Mr3zee
Copy link
Collaborator

@Mr3zee Mr3zee commented Aug 12, 2025 •
edited
Loading

Subsystem
Protoc-gen

Problem Description
Google publishes conformance tests for protoc-gen language implementations to test functionality

Solution
Setup our conformance tests:

  • Added runner executable dependency
  • Added conformance protos and generated code to the repository to track changes
    • Only proto3 are generated due to GROUPS unsupported in protoc-gen
  • Added junit tests to mimic conformance tests
  • Fixed:
    • Generation for single package in path
    • Logging in protoc-gen plugins
    • Package names
    • Enums in repeated fields
    • Gradle plugin lazy tasks creation order
    • Gradle plugin initialization order bug
    • packed enum generation
    • boolSize function
    • Well-Known types
    • Explicit API mode

Current test status:

=== Conformance Test Results ===
Total baseline tests:   5545
[+] Passed tests:       1188
[-] Failed tests:       4357

@Mr3zee Mr3zee self-assigned this Aug 12, 2025
@Mr3zee Mr3zee added the infra Infrastructure changes (Gradle, CI, project setup, etc) label Aug 12, 2025
Base automatically changed from grpc-protobuf to grpc-common August 13, 2025 13:05
@Mr3zee
Set up protobuf conformance tests:
2130297 
- Added runner exe
- Added conformance protos and generated code
- Fixed low-hanging gradle and protoc-gen issues
@Mr3zee Mr3zee force-pushed the protobuf-conformance branch from f7f386d to 2130297 Compare August 13, 2025 14:47
@Mr3zee Mr3zee requested a review from Jozott00 August 15, 2025 09:17
@Mr3zee Mr3zee marked this pull request as ready for review August 15, 2025 09:17
@Mr3zee Mr3zee force-pushed the protobuf-conformance branch from 214d268 to 2ab9953 Compare August 15, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jozott00 Jozott00 Awaiting requested review from Jozott00

Assignees

@Mr3zee Mr3zee

Labels
infra Infrastructure changes (Gradle, CI, project setup, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Mr3zee