protobuf: Add support for deprecated groups #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@Jozott00 looks like auto-lint on commit was applied to some generated classes |
Mr3zee
approved these changes
Sep 10, 2025
Member
Mr3zee
left a comment
Mr3zee
left a comment
There was a problem hiding this comment.
⚡️⚡️⚡️
Do we enable proto2 tests and editions then?
...-gen/protobuf/src/main/kotlin/kotlinx/rpc/protoc/gen/ModelToProtobufKotlinCommonGenerator.kt
Show resolved
Hide resolved
...-gen/protobuf/src/main/kotlin/kotlinx/rpc/protoc/gen/ModelToProtobufKotlinCommonGenerator.kt
Show resolved
Hide resolved
Collaborator
Author
|
Proto2, Proto2 Editions and Editions2023 conformance tests are activated in the next PR. |
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Mr3zee
pushed a commit
that referenced
this pull request
Oct 27, 2025
* protobuf: Add Groups encode/decode Signed-off-by: Johannes Zottele <[email protected]> * protobuf: Add group lists Signed-off-by: Johannes Zottele <[email protected]> * protobuf: Fix unexpected END_GROUP Signed-off-by: Johannes Zottele <[email protected]> * protobuf: Add oneof groups test Signed-off-by: Johannes Zottele <[email protected]> * protobuf: Fix name in ConformanceTest.kt Signed-off-by: Johannes Zottele <[email protected]> * pb: Revert autolint changes Signed-off-by: Johannes Zottele <[email protected]> * pb: Remove copyright headers Signed-off-by: Johannes Zottele <[email protected]> --------- Signed-off-by: Johannes Zottele <[email protected]>
Mr3zee
pushed a commit
that referenced
this pull request
Nov 12, 2025
* protobuf: Add Groups encode/decode Signed-off-by: Johannes Zottele <[email protected]> * protobuf: Add group lists Signed-off-by: Johannes Zottele <[email protected]> * protobuf: Fix unexpected END_GROUP Signed-off-by: Johannes Zottele <[email protected]> * protobuf: Add oneof groups test Signed-off-by: Johannes Zottele <[email protected]> * protobuf: Fix name in ConformanceTest.kt Signed-off-by: Johannes Zottele <[email protected]> * pb: Revert autolint changes Signed-off-by: Johannes Zottele <[email protected]> * pb: Remove copyright headers Signed-off-by: Johannes Zottele <[email protected]> --------- Signed-off-by: Johannes Zottele <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Protobuf
Problem Description
Groups were not supported or implemented, and they even caused a crash when the wire contained a GROUP tag.
Solution
The PR implements group support, which resulted in 10 more tests passing the conformance tests, specifically proto3 tests that validate the correct parsing error behavior for invalid
END_GROUPtests.However, functionality is also implemented for proto2 and editions that actually use groups in their proto file.