Skip to content

Conversation

rnett
Copy link
Contributor

@rnett rnett commented Oct 15, 2025

Subsystem
Descriptors.

Problem Description
Replaces #503.

See #496. Despite generating a list of a descriptor's callables, it's never exposed.

Solution
This PR makes the generated property public and adds a corresponding overridden property to the interface.

ATTENTION

I don't have the necessary permissions to update labels.

ApiVersioningTest has some failures but they are present on development, too.

@rnett rnett changed the title Rnett/expose descriptor callable map Expose RpcServiceDescriptor.callables Oct 15, 2025
@rnett rnett marked this pull request as ready for review October 15, 2025 00:15
@rnett rnett requested a review from Mr3zee October 16, 2025 00:23
@Mr3zee Mr3zee added the feature New feature or request label Oct 16, 2025
Copy link
Member

@Mr3zee Mr3zee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll fix compat test issues locally, thank you for your contribution!

@Mr3zee Mr3zee merged commit 8a2374f into Kotlin:main Oct 16, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants