-
Notifications
You must be signed in to change notification settings - Fork 40
grpc: Add Call Metadata (Headers and Trailers) #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work!
Couple of minor things below and a question:
Do you plan to add serializable versions of get/append/etc in a separate PR?
grpc/grpc-core/src/commonMain/kotlin/kotlinx/rpc/grpc/GrpcMetadata.kt
Outdated
Show resolved
Hide resolved
grpc/grpc-core/src/nativeMain/kotlin/kotlinx/rpc/grpc/GrpcMetadata.native.kt
Outdated
Show resolved
Hide resolved
|
@Mr3zee I think I misunderstood the outcome of our last discussion about the serialization API for metadata. My understanding was, that we drop the API, as a full implementation would require differentiation between binary serialization and ascii serialization. So we leave it up to the user who can just call the upcoming But I am also fine with adding API for binary serialization only. In that case, should we call them |
f2a6e81 to
cb957f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work!
Subsystem
gRPC
Problem Description
Before this, we had no support for passing gRPC metadata between the client and the server.
Solution
This PR solves this on JVM and Native by providing a custom interface (
GrpcMetadata).