Skip to content

Conversation

@Jozott00
Copy link
Collaborator

Subsystem
gRPC

Problem Description
Before this, we had no support for passing gRPC metadata between the client and the server.

Solution
This PR solves this on JVM and Native by providing a custom interface (GrpcMetadata).

@Jozott00 Jozott00 self-assigned this Oct 21, 2025
@Jozott00 Jozott00 added the feature New feature or request label Oct 21, 2025
@Jozott00 Jozott00 marked this pull request as ready for review October 22, 2025 09:41
@Jozott00 Jozott00 requested a review from Mr3zee October 22, 2025 09:41
Copy link
Member

@Mr3zee Mr3zee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work!
Couple of minor things below and a question:
Do you plan to add serializable versions of get/append/etc in a separate PR?

@Jozott00
Copy link
Collaborator Author

@Mr3zee I think I misunderstood the outcome of our last discussion about the serialization API for metadata. My understanding was, that we drop the API, as a full implementation would require differentiation between binary serialization and ascii serialization. So we leave it up to the user who can just call the upcoming codec() function to encode/decode the object.

But I am also fine with adding API for binary serialization only. In that case, should we call them get(key: Key) or getBinary(key: Key) to reflect that the serialization is binary?

@Jozott00 Jozott00 requested a review from Mr3zee October 28, 2025 08:58
Copy link
Member

@Mr3zee Mr3zee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@Jozott00 Jozott00 merged commit 76b381d into grpc-common Oct 30, 2025
6 of 7 checks passed
@Jozott00 Jozott00 deleted the grpc/metadata branch October 30, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants