pb: Add ProtobufConfig with discardUnknownFields configuration
#569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jozott00
force-pushed
the
pb/codec-config
branch
from
5579897 to
775e741
Compare
Mr3zee
approved these changes
Feb 9, 2026
Comment on lines
+117
to
+118
|
|
||
|
|
| * val myCodec = codec<MyMessage>(config) | ||
| * | ||
| * // Or pass config per-operation | ||
| * val decoded = codec.decode(stream, ProtobufConfig(discardUnknownFields = true)) |
Member
There was a problem hiding this comment.
Can be shorter with codec.decode(stream, config) (config is from the line above)
| } | ||
|
|
||
| encoder.writeMessage(1, firstPart as OtherInternal) { encodeWith(encoder) } | ||
| encoder.writeMessage(1, firstPart as OtherInternal) { encodeWith(encoder, null) } |
Member
There was a problem hiding this comment.
Should the parameter be with a default null value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Protobuf
Problem Description
Currently, it is not possible to tell the protobuf decoder to discard unknown fields during message parsing.
Solution
This PR adds the
ProtobufConfigclass that holds thediscardUnknownFieldsproperty.If passed to the
MessageCodec, it tells the generated protobuf decoder to discard unknown fields.