pb: Add MARSHALLER and DESCRIPTOR object to group messages#589
Merged
Jozott00 merged 2 commits intogrpc-commonfrom Mar 3, 2026
Merged
pb: Add MARSHALLER and DESCRIPTOR object to group messages#589Jozott00 merged 2 commits intogrpc-commonfrom
Jozott00 merged 2 commits intogrpc-commonfrom
Conversation
Mr3zee
approved these changes
Mar 2, 2026
...-gen/protobuf/src/main/kotlin/kotlinx/rpc/protoc/gen/ModelToProtobufKotlinCommonGenerator.kt
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subsystem
Protobuf
Problem Description
Group messages were not annotated with
@GeneratedProtoMessagebecause they didn't have a marshaller and descriptor object.Solution
Now each group message also has a
MARSHALLERobject that allows encoding and decoding of a standalone group message. The encoding and decoding works like for normal functions, so noGROUP_STARTandGROUP_ENDtag are written or read.While this isn't something that the protobuf spec intends, it doesn't violate any specs and allows us to annotate it with
@GeneratedProtoMessage.