Experimental annotation revisit:

  * Mark our API annotation as experimental with corresponding warning or error
  * Get rid of workaround for new inference bug
  * Migrate to compiler arguments instead of annotations

Author: qwwdfsad

build.gradle

@@ -170,14 +170,24 @@ configure(subprojects.findAll { !unpublished.contains(it.name) }) {
             }
         }
     }
-    
+
     if (platform == "jvm") {
         dokkaJavadoc.dependsOn project(":$coroutines_core").dokka
         // dump declarations from main JVM module for binary-compatibility-validator
         compileKotlin {
             kotlinOptions.freeCompilerArgs += ["-Xdump-declarations-to=${buildDir}/visibilities.json"]
         }
     }
+
+
+    tasks.withType(org.jetbrains.kotlin.gradle.tasks.AbstractKotlinCompile).all {
+        kotlinOptions.freeCompilerArgs += ["-Xuse-experimental=kotlin.Experimental",
+                                           "-Xuse-experimental=kotlin.experimental.ExperimentalTypeInference",
+                                           "-Xuse-experimental=kotlinx.coroutines.ExperimentalCoroutinesApi",
+                                           "-Xuse-experimental=kotlinx.coroutines.ObsoleteCoroutinesApi",
+                                           "-Xuse-experimental=kotlinx.coroutines.InternalCoroutinesApi"]
+
+    }
 }
 
 // main deployment task

common/kotlinx-coroutines-core-common/src/Annotations.kt

@@ -11,8 +11,8 @@ package kotlinx.coroutines
  * the semantics of their behavior may change in some way that may break some code.
  */
 @MustBeDocumented
-@Retention(value = AnnotationRetention.SOURCE)
-// todo: Experimental WARNING
+@Retention(value = AnnotationRetention.BINARY)
+@Experimental(level = Experimental.Level.WARNING)
 public annotation class ExperimentalCoroutinesApi
 
 /**
@@ -22,8 +22,8 @@ public annotation class ExperimentalCoroutinesApi
  * so they cannot be deprecated right away.
  */
 @MustBeDocumented
-@Retention(value = AnnotationRetention.SOURCE)
-// todo: Experimental WARNING
+@Retention(value = AnnotationRetention.BINARY)
+@Experimental(level = Experimental.Level.WARNING)
 public annotation class ObsoleteCoroutinesApi
 
 /**
@@ -33,6 +33,6 @@ public annotation class ObsoleteCoroutinesApi
  *
  * @suppress **This an internal API and should not be used from general code.**
  */
-@Retention(value = AnnotationRetention.SOURCE)
-// todo: Experimental ERROR
+@Retention(value = AnnotationRetention.BINARY)
+@Experimental(level = Experimental.Level.ERROR)
 public annotation class InternalCoroutinesApi

common/kotlinx-coroutines-core-common/src/Builders.common.kt

@@ -4,7 +4,6 @@
 
 @file:JvmMultifileClass
 @file:JvmName("BuildersKt")
-@file:UseExperimental(ExperimentalTypeInference::class)
 
 package kotlinx.coroutines
 
@@ -14,7 +13,6 @@ import kotlinx.coroutines.intrinsics.*
 import kotlinx.coroutines.selects.*
 import kotlin.coroutines.*
 import kotlin.coroutines.intrinsics.*
-import kotlin.experimental.*
 
 // --------------- launch ---------------
 
@@ -43,7 +41,6 @@ import kotlin.experimental.*
  * @param start coroutine start option. The default value is [CoroutineStart.DEFAULT].
  * @param block the coroutine code which will be invoked in the context of the provided scope.
  **/
-@BuilderInference
 public fun CoroutineScope.launch(
     context: CoroutineContext = EmptyCoroutineContext,
     start: CoroutineStart = CoroutineStart.DEFAULT,
@@ -78,7 +75,6 @@ public fun CoroutineScope.launch(
  * @param start coroutine start option. The default value is [CoroutineStart.DEFAULT].
  * @param block the coroutine code.
  */
-@BuilderInference
 public fun <T> CoroutineScope.async(
     context: CoroutineContext = EmptyCoroutineContext,
     start: CoroutineStart = CoroutineStart.DEFAULT,

common/kotlinx-coroutines-core-common/src/CoroutineContext.common.kt

@@ -2,14 +2,10 @@
  * Copyright 2016-2018 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license.
  */
 
-@file:UseExperimental(ExperimentalTypeInference::class)
-
 package kotlinx.coroutines
 
 import kotlin.coroutines.*
-import kotlin.experimental.*
 
-@BuilderInference
 public expect fun CoroutineScope.newCoroutineContext(context: CoroutineContext): CoroutineContext
 
 internal expect fun createDefaultDispatcher(): CoroutineDispatcher

common/kotlinx-coroutines-core-common/src/CoroutineScope.kt

@@ -2,15 +2,12 @@
  * Copyright 2016-2018 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license.
  */
 
-@file:UseExperimental(ExperimentalTypeInference::class)
-
 package kotlinx.coroutines
 
 import kotlinx.coroutines.internal.*
 import kotlinx.coroutines.intrinsics.*
 import kotlin.coroutines.intrinsics.*
 import kotlin.coroutines.*
-import kotlin.experimental.*
 
 /**
  * Defines a scope for new coroutines. Every coroutine builder
@@ -74,7 +71,6 @@ public interface CoroutineScope {
  *
  * This is a shorthand for `CoroutineScope(thisScope + context)`.
  */
-@BuilderInference
 public operator fun CoroutineScope.plus(context: CoroutineContext): CoroutineScope =
     ContextScope(coroutineContext + context)
 
@@ -94,7 +90,6 @@ public operator fun CoroutineScope.plus(context: CoroutineContext): CoroutineSco
  * [isActive][kotlinx.coroutines.isActive] and [Job.isActive].
  */
 @Suppress("EXTENSION_SHADOWED_BY_MEMBER")
-@BuilderInference
 public val CoroutineScope.isActive: Boolean
     get() = coroutineContext[Job]?.isActive ?: true
 
@@ -164,7 +159,7 @@ object GlobalScope : CoroutineScope {
  */
 public suspend fun <R> coroutineScope(block: suspend CoroutineScope.() -> R): R =
     suspendCoroutineUninterceptedOrReturn { uCont ->
-        val coroutine = ScopeCoroutine<R>(uCont.context, uCont)
+        val coroutine = ScopeCoroutine(uCont.context, uCont)
         coroutine.startUndispatchedOrReturn(coroutine, block)
     }
 

common/kotlinx-coroutines-core-common/src/Deferred.kt

@@ -2,14 +2,9 @@
  * Copyright 2016-2018 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license.
  */
 
-@file:UseExperimental(ExperimentalTypeInference::class)
-
 package kotlinx.coroutines
 
-import kotlinx.coroutines.intrinsics.*
 import kotlinx.coroutines.selects.*
-import kotlin.coroutines.*
-import kotlin.experimental.*
 
 /**
  * Deferred value is a non-blocking cancellable future — it is a [Job] that has a result.

common/kotlinx-coroutines-core-common/src/channels/Broadcast.kt

@@ -2,16 +2,13 @@
  * Copyright 2016-2018 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license.
  */
 
-@file:UseExperimental(ExperimentalTypeInference::class)
-
 package kotlinx.coroutines.channels
 
 import kotlinx.coroutines.*
 import kotlinx.coroutines.channels.Channel.Factory.CONFLATED
 import kotlinx.coroutines.channels.Channel.Factory.UNLIMITED
 import kotlinx.coroutines.intrinsics.*
 import kotlin.coroutines.*
-import kotlin.experimental.*
 
 /**
  * Broadcasts all elements of the channel.
@@ -65,7 +62,6 @@ fun <E> ReceiveChannel<E>.broadcast(
  * @param onCompletion optional completion handler for the producer coroutine (see [Job.invokeOnCompletion]).
  * @param block the coroutine code.
  */
-@BuilderInference
 public fun <E> CoroutineScope.broadcast(
     context: CoroutineContext = EmptyCoroutineContext,
     capacity: Int = 1,

common/kotlinx-coroutines-core-common/src/channels/Produce.kt

@@ -2,14 +2,10 @@
  * Copyright 2016-2018 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license.
  */
 
-@file:UseExperimental(ExperimentalTypeInference::class)
-
 package kotlinx.coroutines.channels
 
 import kotlinx.coroutines.*
-import kotlinx.coroutines.channels.Channel.Factory.UNLIMITED
 import kotlin.coroutines.*
-import kotlin.experimental.*
 
 /**
  * Scope for [produce][CoroutineScope.produce] coroutine builder.
@@ -61,7 +57,6 @@ public interface ProducerScope<in E> : CoroutineScope, SendChannel<E> {
  * @param block the coroutine code.
  */
 @ExperimentalCoroutinesApi
-@BuilderInference
 public fun <E> CoroutineScope.produce(
     context: CoroutineContext = EmptyCoroutineContext,
     capacity: Int = 0,
@@ -78,7 +73,6 @@ public fun <E> CoroutineScope.produce(
  * @suppress **This an internal API and should not be used from general code.**
  *           onCompletion parameter will be redesigned.
  */
-@BuilderInference
 @InternalCoroutinesApi
 public fun <E> CoroutineScope.produce(
     context: CoroutineContext = EmptyCoroutineContext,

core/kotlinx-coroutines-core/src/CoroutineContext.kt

@@ -2,15 +2,12 @@
  * Copyright 2016-2018 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license.
  */
 
-@file:UseExperimental(ExperimentalTypeInference::class)
-
 package kotlinx.coroutines
 
 import kotlinx.coroutines.internal.*
 import kotlinx.coroutines.scheduling.*
 import java.util.concurrent.atomic.*
 import kotlin.coroutines.*
-import kotlin.experimental.*
 
 private val COROUTINE_ID = AtomicLong()
 
@@ -55,7 +52,6 @@ internal actual fun createDefaultDispatcher(): CoroutineDispatcher =
  * **Note: This is an experimental api.**
  *   Behavior of this function may change in the future with respect to its support for debugging facilities.
  */
-@BuilderInference
 @ExperimentalCoroutinesApi
 public actual fun CoroutineScope.newCoroutineContext(context: CoroutineContext): CoroutineContext {
     val combined = coroutineContext + context

core/kotlinx-coroutines-core/src/channels/Actor.kt

@@ -2,16 +2,12 @@
  * Copyright 2016-2018 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license.
  */
 
-@file:UseExperimental(ExperimentalTypeInference::class)
-
 package kotlinx.coroutines.channels
 
 import kotlinx.coroutines.*
-import kotlinx.coroutines.channels.Channel.Factory.UNLIMITED
 import kotlinx.coroutines.intrinsics.*
 import kotlinx.coroutines.selects.*
 import kotlin.coroutines.*
-import kotlin.experimental.*
 
 /**
  * Scope for [actor][GlobalScope.actor] coroutine builder.
@@ -109,7 +105,6 @@ public interface ActorScope<E> : CoroutineScope, ReceiveChannel<E> {
  * @param block the coroutine code.
  */
 @ObsoleteCoroutinesApi
-@BuilderInference
 public fun <E> CoroutineScope.actor(
     context: CoroutineContext = EmptyCoroutineContext,
     capacity: Int = 0,