Skip to content

Fix flaky shared flow subscription #4489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: fix-flaky-shared-flow-subscription
Choose a base branch
from

Conversation

murfel
Copy link
Contributor

@murfel murfel commented Jul 25, 2025

@murfel murfel requested a review from dkhalanskyjb July 28, 2025 10:58
@dkhalanskyjb
Copy link
Contributor

The change makes sense, thanks! However, the failing tests are important. This changes the behavior of other operators non-trivially, and we need to evaluate how big the change is. Could you please classify the tests into those that fail reasonably and those that should ideally still pass? Then, we'll figure out if we need to isolate the change to just collectLatest and will have an idea of how big the impact of the change is.

Comment on lines 94 to 95
fun testBaseline() =
checkBuffer(-1) { this }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated: Idea gives a warning on this: Flow is constructed but not used. That's a false positive, right? I'll report it if so.

import kotlinx.coroutines.*
import kotlinx.coroutines.channels.*
import kotlinx.coroutines.testing.*
Copy link
Contributor Author

@murfel murfel Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated: L1: Do we need the suppression on Line 1? I don't quite understand how it is relevant here.

@murfel
Copy link
Contributor Author

murfel commented Aug 11, 2025

I aimed to fix all tests but these (conflicting with #4493)

  •      🔴 kotlinx.coroutines.flow.FlatMapLatestTest.testSwitchRendevouzBuffer[jvm]
  •      🔴 kotlinx.coroutines.flow.TransformLatestTest.testSwitchRendezvousBuffer[jvm]
  •      🔴 kotlinx.coroutines.flow.TransformLatestTest.testSwitchBuffer[jvm]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants