propagateExceptionFinalResort-nodejs-reportError

CHANGES.md

@@ -1,5 +1,8 @@
 # Change log for kotlinx.coroutines
 
+## Version 1.10.3
+* `propagateExceptionFinalResort` now throws instead of logging on the `js` and `wasmJS` targets.
+
 ## Version 1.10.2
 
 * Fixed the `kotlinx-coroutines-debug` JAR file including the `module-info.class` file twice, resulting in failures in various tooling (#4314). Thanks, @RyuNen344!

kotlinx-coroutines-core/js/src/internal/CoroutineExceptionHandlerImpl.kt

@@ -5,3 +5,7 @@ import kotlin.js.unsafeCast
 internal actual external interface JsAny
 
 internal actual fun Throwable.toJsException(): JsAny = this.unsafeCast<JsAny>()
+
+internal actual fun propagateExceptionFinalResort(exception: Throwable) {
+    throwAsync(exception.toJsException())
+}

kotlinx-coroutines-core/js/test/PropagateExceptionFinalResortTest.kt

@@ -8,6 +8,7 @@ class PropagateExceptionFinalResortTest : TestBase() {
     @BeforeTest
     private fun removeListeners() {
         // Remove a Node.js's internal listener, which prints the exception to stdout.
+        // https://nodejs.org/api/process.html#event-uncaughtexception
         js("""
             globalThis.originalListeners = process.listeners('uncaughtException');
             process.removeAllListeners('uncaughtException');

kotlinx-coroutines-core/jsAndWasmJsShared/src/internal/CoroutineExceptionHandlerImpl.kt

@@ -11,7 +11,3 @@ internal expect fun Throwable.toJsException(): JsAny
  * rather than in the current execution branch.
  */
 internal fun throwAsync(e: JsAny): Unit = js("setTimeout(function () { throw e }, 0)")
-
-internal actual fun propagateExceptionFinalResort(exception: Throwable) {
-    throwAsync(exception.toJsException())
-}

kotlinx-coroutines-core/wasmJs/src/internal/CoroutineExceptionHandlerImpl.kt

@@ -2,6 +2,10 @@ package kotlinx.coroutines.internal
 
 internal actual typealias JsAny = kotlin.js.JsAny
 
+internal external object globalThis : JsAny {
+    val reportError: ((error: JsAny) -> Unit)?
+}
+
 internal actual fun Throwable.toJsException(): JsAny =
     toJsError(message, this::class.simpleName, stackTraceToString())
 
@@ -14,3 +18,15 @@ internal fun toJsError(message: String?, className: String?, stack: String?): Js
     return error;
     """)
 }
+
+internal actual fun propagateExceptionFinalResort(exception: Throwable) {
+    val jsException = exception.toJsException()
+    // https://github.com/JetBrains/kotlin-wrappers/blob/master/kotlin-browser/src/webMain/generated/web/errors/reportError.kt
+    if (globalThis.reportError != null) {
+        // Modern browsers, Deno, Bun, etc.
+        globalThis.reportError(jsException)
+    } else {
+        // Old Safari, Node.js
+        throwAsync(jsException)
+    }
+}

kotlinx-coroutines-core/wasmJs/test/PropagateExceptionFinalResortTest.kt

@@ -15,9 +15,9 @@ class PropagateExceptionFinalResortTest : TestBase() {
     }
 
     /*
-     * Test that `propagateExceptionFinalResort` re-throws the exception on Wasm/JS.
+     * Test that `propagateExceptionFinalResort` re-throws the exception on wasmJS.
      *
-     * It is checked by setting up an exception handler within Wasm/JS.
+     * It is checked by setting up an exception handler within wasmJS.
      */
     @Test
     fun testPropagateExceptionFinalResortReThrowsOnWasmJS() = runTest {
@@ -31,6 +31,7 @@ class PropagateExceptionFinalResortTest : TestBase() {
 }
 
 private fun addUncaughtExceptionHandlerHelper() {
+    // https://nodejs.org/api/process.html#event-uncaughtexception
     js("""
             globalThis.exceptionCaught = false;
             globalThis.exceptionHandler = function(e) {