Docker publish workflow: Create docker-publish.yml#1776
Docker publish workflow: Create docker-publish.yml#1776pbiering merged 1 commit intoKozea:masterfrom
Conversation
|
1.2 (major.minor) + 1 (major) makes no sense, only (latest) release + (latest) upstream makes sense, please adjust, thank you! |
* Build using the `Dockerfile` and publish to `ghcr.io`
* Trigger on release
* Create the following tags based on the release git tag.
For example, for a git tag `v1.2.3`, the following docker tags will be created:
* `1.2.3` (version)
* `latest`
Note: Depends on the git tag following semantic versioning.
22c1e04 to
9805c62
Compare
Thank you for the review. I have removed the following as per your suggestion:
|
|
@kalsi-avneet - would it make sense to create in addition "latest" on every push or pull-request using the commit hash instead of the release in the name? And somehow remove former "latest" ones in a cycled way, e.g. keep the last 10 images or only with creation time of the last 30 days? |
|
Hi @pbiering,
Let me confirm my understanding. The requirement is to create a docker image whenever:
And the tag of the docker image should be the commit hash. The above should be done in addition to creating images for every release. Please confirm if my understanding same as yours. I believe a few things need to be considered and discussed:
Yes, I think it would be possible. But the implementation would differ based on where the images are stored - github registry or dockerhub registry. |
|
instead of using push/pull-request as a trigger, can be a nightly image creation scheduled? Or e.g. trigger the "upstream" image generation manually from time to time? |
Yes, that can be done. I will create a PR for this. Later, I will create another PR for cleanup |
|
Raised #1779 for your request:
Summary of PR:
|
Build using the
Dockerfileand publish toghcr.io(Github's container registry)Trigger on release
Create the following tags based on the release git tag.
For example, for a git tag
v1.2.3, the following docker tags will be created:1.2.3(version)<-- Removed as per review1.2(major.minor)<-- Removed as per review1(major)latestNote: Depends on the git tag following semantic versioning.