Skip to content

Misc improvements to UI#2014

Merged
pbiering merged 5 commits intoKozea:masterfrom
maxberger:master
Mar 5, 2026
Merged

Misc improvements to UI#2014
pbiering merged 5 commits intoKozea:masterfrom
maxberger:master

Conversation

@maxberger
Copy link
Contributor

@maxberger maxberger commented Mar 4, 2026

  • Add github workflow which actually runs the integ tests
  • DeleteCollectionScene: Fix JS linter errors
  • Add confirmation on use of delete button
  • Fix: Show only tokens in share by token list

@maxberger maxberger changed the title Added github workflow for integ tests and run automaticall on push/pull requests Misc improvements to UI Mar 4, 2026
@pbiering pbiering added this to the 3.7.0 milestone Mar 5, 2026
@pbiering pbiering added the sharing collection sharing label Mar 5, 2026
Copy link
Collaborator

@pbiering pbiering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it not better to merge the integ_test.yml into current test.yml to be able to useneeds and start integration tests only after "test-ubuntu-python-newest" has successfully passed?

@maxberger
Copy link
Contributor Author

would it not better to merge the integ_test.yml into current test.yml to be able to useneeds and start integration tests only after "test-ubuntu-python-newest" has successfully passed?

done

Copy link
Collaborator

@pbiering pbiering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@pbiering pbiering merged commit bc3c2df into Kozea:master Mar 5, 2026
29 checks passed
@pbiering
Copy link
Collaborator

pbiering commented Mar 8, 2026

@maxberger - is the "JS Type Check" independent from "integ-test" or should this be cascaded? If second, please add an additional dependency.

@maxberger
Copy link
Contributor Author

@maxberger - is the "JS Type Check" independent from "integ-test" or should this be cascaded? If second, please add an additional dependency.

Both are independent. The js type check is more like a linter (do we have valid JavaScript?), the integ test tests everything including the server (when I click here does the right thing happen).

I could even think about adding unit tests - but right now I think that would be too much.

@pbiering pbiering added the webui built-in WebUI label Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sharing collection sharing webui built-in WebUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants