Improve Authentication handling in webUI#2036
Improve Authentication handling in webUI#2036maxberger wants to merge 2 commits intoKozea:masterfrom
Conversation
the original behavior is intended, reverse proxies have to exclude |
I think there is some confusion here: The check is not on the .web/ directory itself. index.html, and all .JS in it is loaded as is, and as you said needs to be free from authentication. What this does internally is: Before showing the login screen, it tries a propfind for the current users collection without credentials. If this one returns 401, we know we need to send all future requests with user/pass (previous behavior). The only difference you see is the result of this call in the console. However, if the call succeeds, e.g. because the user has valid credentials already (e.g. through x-remote-user or other methods, of course only if configured as auth), then this and all future calls are sent without username/password; they would not matter anyways, and the login screen can be skipped. |
Unfortunately this does cause a message in the console since the authentication is checked on first load; that message can be safely ignored.