[CI] Testing the C++20 compilation

.github/workflows/ci.yml

@@ -392,6 +392,8 @@ jobs:
         cmake -H"${KRATOS_SOURCE}" -B"${KRATOS_BUILD}/${KRATOS_BUILD_TYPE}" \
         -DUSE_MPI=ON \
         -DCMAKE_POLICY_VERSION_MINIMUM=3.5 \
+        -DBOOST_ROOT="/workspace/boost/boost_1_87_0" \
+        -DBoost_NO_SYSTEM_PATHS=ON \
         -DTRILINOS_INCLUDE_DIR="/usr/include/trilinos" \
         -DTRILINOS_LIBRARY_DIR="/usr/lib/x86_64-linux-gnu" \
         -DTRILINOS_LIBRARY_PREFIX="trilinos_" \
@@ -518,7 +520,7 @@ jobs:
           -DBOOST_ROOT="%TEMP%\boost"                         ^
           -DCMAKE_CXX_FLAGS="/Od /we4661 /we4804 /WX /wd4996" ^
           -DCMAKE_POLICY_VERSION_MINIMUM=3.5                  ^
-          -DKRATOS_USE_PCH=ON                                 ^
+          -DKRATOS_USE_PCH=OFF                                ^
           -DFORCE_LOCAL_ZLIB_COMPILATION=ON                   || goto :error
 
         cmake --build "%KRATOS_BUILD%\%KRATOS_BUILD_TYPE%" --target all_build -- /property:configuration=%KRATOS_BUILD_TYPE% /p:Platform=x64 || goto :error

.github/workflows/intel_configure.sh

@@ -60,6 +60,8 @@ cmake -H"${KRATOS_SOURCE}" -B"${KRATOS_BUILD}/${KRATOS_BUILD_TYPE}" \
 ${KRATOS_CMAKE_OPTIONS_FLAGS} \
 -DUSE_MPI=ON \
 -DPYTHON_EXECUTABLE="/usr/bin/python3.10" \
+-DBOOST_ROOT="/workspace/boost/boost_1_87_0" \
+-DBoost_NO_SYSTEM_PATHS=ON \
 -DCMAKE_CXX_FLAGS="${KRATOS_CMAKE_CXX_FLAGS} -O3 -Wall -Werror-all -diag-disable 1478 -diag-disable 1786" \
 -DTRILINOS_INCLUDE_DIR="/usr/include/trilinos" \
 -DTRILINOS_LIBRARY_DIR="/usr/lib/x86_64-linux-gnu" \

CMakeLists.txt

@@ -1,7 +1,7 @@
 cmake_minimum_required (VERSION 3.15.0)
 
 project (KratosMultiphysics)
-set (CMAKE_CXX_STANDARD 17)
+set (CMAKE_CXX_STANDARD 20)
 set (CMAKE_CXX_STANDARD_REQUIRED ON)
 set (CMAKE_CXX_EXTENSIONS OFF)
 
@@ -170,6 +170,11 @@ ELSE(CMAKE_VERSION VERSION_LESS "3.16.0")
     ENDIF(CMAKE_UNITY_BUILD MATCHES ON)
 ENDIF(CMAKE_VERSION VERSION_LESS "3.16.0")
 
+# Add /utf-8 as a source file encoding flag for MSVC
+if(MSVC)
+    add_compile_options("/utf-8")
+endif()
+
 # Get subversion data. This is done automagically by the cmakes
 include (GenerateExportHeader)
 

README.md

@@ -16,7 +16,7 @@
 [license-image]: https://img.shields.io/badge/license-BSD-green.svg?style=flat
 [license]: https://github.com/KratosMultiphysics/Kratos/blob/master/kratos/license.txt
 
-[c++-image]: https://img.shields.io/badge/C++-17-blue.svg?style=flat&logo=c%2B%2B
+[c++-image]: https://img.shields.io/badge/C++-20-blue.svg?style=flat&logo=c%2B%2B
 [c++standard]: https://isocpp.org/std/the-standard
 
 [Nightly-Build]: https://github.com/KratosMultiphysics/Kratos/workflows/Nightly%20Build/badge.svg

applications/CoSimulationApplication/custom_external_libraries/CoSimIO/co_sim_io/sources/communication/base_socket_communication.cpp

@@ -19,7 +19,7 @@ namespace CoSimIO {
 namespace Internals {
 
 template<class TSocketType>
-BaseSocketCommunication<TSocketType>::~BaseSocketCommunication<TSocketType>()
+BaseSocketCommunication<TSocketType>::~BaseSocketCommunication()
 {
     CO_SIM_IO_TRY
 

applications/ConvectionDiffusionApplication/custom_utilities/move_particle_utility.h

@@ -205,7 +205,6 @@ namespace Kratos
 			mvector_of_particle_pointers_vectors.resize(mnelems);
             //int artz;
             //std::cin >> artz;
-			int i_int=0; //careful! it's not the id, but the position inside the array!
 			std::cout << "about to create particles" << std::endl;
 			//now we seed: LOOP IN ELEMENTS
 			//using loop index, DO NOT parallelize this! change lines : mparticles_in_elems_pointers((ii*mmaximum_number_of_particles)+mparticles_in_elems_integers(ii)) = pparticle; and the next one
@@ -230,7 +229,6 @@ namespace Kratos
 
 				Geometry< Node >& geom = ielem->GetGeometry();
 				//unsigned int elem_id = ielem->Id();
-				//mareas_vector[i_int]=CalculateArea(geom); UNUSED SO COMMENTED
 				ComputeGaussPointPositions_initial(geom, pos, N); //we also have the standard (4), and 45
 				//now we seed the particles in the current element
 				for (unsigned int j = 0; j < pos.size1(); j++)
@@ -257,7 +255,6 @@ namespace Kratos
 					 number_of_particles++ ;
 
 				}
-				++i_int;
 			}
 
 			m_nparticles=particle_id; //we save the last particle created as the total number of particles we have. For the moment this is true.
@@ -1173,8 +1170,6 @@ namespace Kratos
 
 			#pragma omp parallel firstprivate(elem_partition) // firstprivate(results)//we will add the nodes in different parts of aux and later assemble everything together, remaming particles ids to get consecutive ids
 			{
-				unsigned int reused_particles=0;
-
 				unsigned int freeparticle = 0; //we start by the first position;
 
 				int k = OpenMPUtils::ThisThread();
@@ -1273,10 +1268,6 @@ namespace Kratos
 							{
 								KRATOS_THROW_ERROR(std::logic_error, "FINISHED THE LIST AND COULDN'T FIND A FREE CELL FOR THE NEW PARTICLE!", "");
 							}
-						    else
-						    {
-								reused_particles++;
-							}
 
 						  }
 					  }

applications/FluidDynamicsApplication/custom_elements/dpg_vms.h

@@ -450,16 +450,17 @@ class DPGVMS : public VMS<TDim, TNumNodes>
 	    ElementBaseType::CalculateLocalVelocityContribution(rDampingMatrix, rRightHandSideVector, rCurrentProcessInfo);
 
 	    //compute boundary term
-	    int boundary_nodes = 0;
+	    // int boundary_nodes = 0;
 	    //unsigned int inside_index = -1;
-	    for (unsigned int i = 0; i < TNumNodes; i++)
-	    {
-	      double nd_flag = this->GetGeometry()[i].FastGetSolutionStepValue(FLAG_VARIABLE);
-	      if (nd_flag == 5.0)
-		boundary_nodes++;
-	      //else
-		//inside_index = i;
-	    }
+
+	    // for (unsigned int i = 0; i < TNumNodes; i++)
+	    // {
+	    //   double nd_flag = this->GetGeometry()[i].FastGetSolutionStepValue(FLAG_VARIABLE);
+	    //   if (nd_flag == 5.0)
+		// boundary_nodes++;
+	    //   //else
+		// //inside_index = i;
+	    // }
 
 
 	/*  if(boundary_nodes == TDim)

external_libraries/delaunator-cpp/include/delaunator.hpp

@@ -318,7 +318,7 @@ Delaunator::Delaunator(std::vector<double> const& in_coords)
 
     hull_start = i0;
 
-    size_t hull_size = 3;
+    // size_t hull_size = 3;
 
     hull_next[i0] = hull_prev[i2] = i1;
     hull_next[i1] = hull_prev[i0] = i2;
@@ -388,7 +388,7 @@ Delaunator::Delaunator(std::vector<double> const& in_coords)
 
         hull_tri[i] = legalize(t + 2);
         hull_tri[e] = t;
-        hull_size++;
+        // hull_size++;
 
         // walk forward through the hull, adding more triangles and flipping recursively
         std::size_t next = hull_next[e];
@@ -398,7 +398,7 @@ Delaunator::Delaunator(std::vector<double> const& in_coords)
             t = add_triangle(next, i, q, hull_tri[i], INVALID_INDEX, hull_tri[next]);
             hull_tri[i] = legalize(t + 2);
             hull_next[next] = next; // mark as removed
-            hull_size--;
+            // hull_size--;
             next = q;
         }
 
@@ -411,7 +411,7 @@ Delaunator::Delaunator(std::vector<double> const& in_coords)
                 legalize(t + 2);
                 hull_tri[q] = t;
                 hull_next[e] = e; // mark as removed
-                hull_size--;
+                // hull_size--;
                 e = q;
             }
         }

kratos/processes/calculate_signed_distance_to_3d_skin_process.h

@@ -534,11 +534,6 @@ class CalculateSignedDistanceTo3DSkinProcess
                                             array_1d<double,4>& Npos,
                                             array_1d<double,4>& Nneg)
     {
-        //count positives
-        int n_positives = 0;
-        for(unsigned int i=0; i<distances.size(); i++)
-            if(distances[i]>0) n_positives++;
-
         //generate the points on the edges at the zero of the distance function
         //generate "father nodes", defined as the end nodes of the edge on which the local point is located
         std::vector< Point > edge_points;

kratos/processes/flux_corrected_transport_convection_process.h

@@ -23,7 +23,6 @@
 
 // Project includes
 #include "containers/edge_based_data_structure.h"
-#include "includes/define.h"
 #include "processes/process.h"
 #include "solving_strategies/strategies/butcher_tableau.h"
 #include "utilities/atomic_utilities.h"
@@ -180,12 +179,12 @@ class FluxCorrectedTransportConvectionProcess : public Process
         const double max_dt = std::min(cfl_dt, mMaxAllowedDt); // Check if the user defined delta time is more restrictive than the CFL one
         const SizeType n_steps = std::ceil(target_dt / max_dt); // Required number of substeps (rounded up)
         const double dt = target_dt / n_steps; // Time increment to be used in the substep loop
-        KRATOS_INFO_IF("FluxCorrectedTransportConvectionProcess", mEchoLevel > 0) << u8"Solving FCT convection with \u0394t = " << dt << u8" (max allowed \u0394t = " <<  max_dt << ")" << std::endl;
+        KRATOS_INFO_IF("FluxCorrectedTransportConvectionProcess", mEchoLevel > 0) << "Solving FCT convection with \u0394t = " << dt << " (max allowed \u0394t = " <<  max_dt << ")" << std::endl;
 
         // Substepping time loop
         for (IndexType step = 1; step <= n_steps; ++step) {
             // Solve current substep
-            KRATOS_INFO_IF("FluxCorrectedTransportConvectionProcess", mEchoLevel > 1) << "Substep = " << step << " - Time = " <<  prev_time << u8" - \u0394t = " << dt << std::endl;
+            KRATOS_INFO_IF("FluxCorrectedTransportConvectionProcess", mEchoLevel > 1) << "Substep = " << step << " - Time = " <<  prev_time << " - \u0394t = " << dt << std::endl;
             this->SolveSubStep(dt);
 
             // Advance in time
@@ -962,4 +961,4 @@ inline std::ostream& operator << (
 }
 ///@}
 
-}  // namespace Kratos.
+}  // namespace Kratos.

kratos/spatial_containers/bins_dynamic.h

@@ -73,7 +73,7 @@ class BinsDynamic
     /// Pointer definition of BinsDynamic
     KRATOS_CLASS_POINTER_DEFINITION(BinsDynamic);
 
-    enum { Dimension = TDimension };
+    constexpr static std::size_t Dimension = TDimension;
 
     using PointType = TPointType;
     using BoundingBoxType = BoundingBox<PointType>;
@@ -345,20 +345,20 @@ class BinsDynamic
         std::array<double, 3> lengths;
         double average_length = 0.0;
 
-        for (int i = 0; i < Dimension; i++) {
+        for (std::size_t i = 0; i < Dimension; i++) {
             lengths[i] = GetMaxPoint()[i] - GetMinPoint()[i];
             average_length += lengths[i];
         }
         average_length *= 1.0 / 3.0;
 
         if (average_length < std::numeric_limits<double>::epsilon()) {
-            for(int i = 0; i < Dimension; i++) {
+            for(std::size_t i = 0; i < Dimension; i++) {
                 mN[i] = 1;
             }
             return;
         }
 
-        for (int i = 0; i < Dimension; i++) {
+        for (std::size_t i = 0; i < Dimension; i++) {
              mN[i] = static_cast<std::size_t>(lengths[i] / average_length * (double)average_number_of_cells) + 1;
 
             if (mN[i] > 1) {