-
Notifications
You must be signed in to change notification settings - Fork 278
[CI] Upgrade boost to 1.87 #13559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Upgrade boost to 1.87 #13559
Conversation
Try windows build with boost 1.87
|
I think it would be Okay, and maybe we should update the Boost in our rocky machines as well. A priori this should not affect much as the actual effect cames with the compiler version not the library itself. FYI @ddiezrod |
In fact we awere using 1.86 instead of 1.87, the change would be minimum |
|
Nice! Just for my own understanding: is boost also included in the kratos containers we have (e.g. kratos-wheelbuilder-windows:latest), or is that completely separate? |
In other words, should it also be upgraded in e.g. https://github.com/KratosMultiphysics/Kratos/blob/master/scripts/docker_files/docker_file_wheelbuilder_windows/Dockerfile#L44? |
|
Huum, the type of fail is quite strange |
I will tackle the fails on the nightly later, probably I will revamp the whole thing now that I have time.
Yep, I will update the dockers so they use the same version as we do in the CI, but first I want the versions that use the downloaded version running, as upgrading the containers will bypass the checks and affect current open PR's |
RiccardoRossi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approvi g on behalf of @KratosMultiphysics/technical-committee
📝 Description
Stand alone version of the boost changes in #13549
@loumalouomega I touched the rocky one, is it ok?
🆕 Changelog
Boost 1.76 -> 1.87