Skip to content

Conversation

@roigcarlo
Copy link
Member

📝 Description
Stand alone version of the boost changes in #13549

@loumalouomega I touched the rocky one, is it ok?

🆕 Changelog
Boost 1.76 -> 1.87

roigcarlo and others added 2 commits June 25, 2025 11:50
Try windows build with boost 1.87
@roigcarlo roigcarlo requested a review from a team as a code owner June 25, 2025 09:53
@roigcarlo roigcarlo enabled auto-merge June 25, 2025 09:54
@loumalouomega
Copy link
Member

I think it would be Okay, and maybe we should update the Boost in our rocky machines as well. A priori this should not affect much as the actual effect cames with the compiler version not the library itself. FYI @ddiezrod

@loumalouomega
Copy link
Member

I think it would be Okay, and maybe we should update the Boost in our rocky machines as well. A priori this should not affect much as the actual effect cames with the compiler version not the library itself. FYI @ddiezrod

In fact we awere using 1.86 instead of 1.87, the change would be minimum

@rfaasse
Copy link
Contributor

rfaasse commented Jun 25, 2025

Nice! Just for my own understanding: is boost also included in the kratos containers we have (e.g. kratos-wheelbuilder-windows:latest), or is that completely separate?

@rfaasse
Copy link
Contributor

rfaasse commented Jun 25, 2025

Nice! Just for my own understanding: is boost also included in the kratos containers we have (e.g. kratos-wheelbuilder-windows:latest), or is that completely separate?

In other words, should it also be upgraded in e.g. https://github.com/KratosMultiphysics/Kratos/blob/master/scripts/docker_files/docker_file_wheelbuilder_windows/Dockerfile#L44?

@loumalouomega
Copy link
Member

Huum, the type of fail is quite strange

@roigcarlo
Copy link
Member Author

roigcarlo commented Jun 25, 2025

Huum, the type of fail is quite strange

I will tackle the fails on the nightly later, probably I will revamp the whole thing now that I have time.

In other words, should it also be upgraded in e.g. https://github.com/KratosMultiphysics/Kratos/blob/master/scripts/docker_files/docker_file_wheelbuilder_windows/Dockerfile#L44?

Yep, I will update the dockers so they use the same version as we do in the CI, but first I want the versions that use the downloaded version running, as upgrading the containers will bypass the checks and affect current open PR's

Copy link
Member

@RiccardoRossi RiccardoRossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approvi g on behalf of @KratosMultiphysics/technical-committee

@roigcarlo roigcarlo merged commit 0b141fd into master Jun 26, 2025
12 of 15 checks passed
@roigcarlo roigcarlo deleted the ci/upgrade-boost branch June 26, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants