[CMake] Improve Boost detection when manually setting BOOST_ROOT#13565
Merged
loumalouomega merged 1 commit intomasterfrom Jul 7, 2025
Merged
[CMake] Improve Boost detection when manually setting BOOST_ROOT#13565loumalouomega merged 1 commit intomasterfrom
Boost detection when manually setting BOOST_ROOT#13565loumalouomega merged 1 commit intomasterfrom
Conversation
loumalouomega
added
FastPR
matekelemen
reviewed
Jun 26, 2025
| if(DEFINED ENV{BOOST_ROOT}) | ||
| set(BOOST_ROOT $ENV{BOOST_ROOT}) | ||
| # Check that boost/any.hpp exists in the BOOST_ROOT include directory | ||
| if(EXISTS "${BOOST_ROOT}/boost/any.hpp") |
Contributor
There was a problem hiding this comment.
why any in particular? Please don't tell me you're planning on using it.
Member
Author
There was a problem hiding this comment.
Is a common file common in all versions (and alphabetically the first)
loumalouomega
referenced
this pull request
Jul 7, 2025
roigcarlo
approved these changes
Jul 7, 2025
Member
|
P.s. approved following the discussion in #13597 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Improve
Boostdetection when manually settingBOOST_ROOT. Without this if later it detects Boost in the system path it will ignore theBOOST_ROOT.🆕 Changelog
Boostdetection when manually settingBOOST_ROOT