-
Notifications
You must be signed in to change notification settings - Fork 278
[CI] Adding new boost version to docker files #13580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
752b718
Updated kratos docker files for ci builds
roigcarlo c303fc1
Remove legacy containers
roigcarlo ed79d3c
Replace ; by &&
roigcarlo edbb4b2
Space
roigcarlo cbcec9f
Layerized dockerfile and updated boost
roigcarlo d5bf929
Update scripts/docker_files/docker_file_ci_ubuntu_22_04/DockerFile
roigcarlo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
131 changes: 72 additions & 59 deletions
131
scripts/docker_files/docker_file_ci_ubuntu_22_04/DockerFile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 0 additions & 61 deletions
61
scripts/docker_files/docker_file_ci_ubuntu_bionic/DockerFile
This file was deleted.
Oops, something went wrong.
25 changes: 0 additions & 25 deletions
25
scripts/docker_files/docker_file_kratos_ubuntu_bionic/DockerFile
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you use multipe
RUNsections? This can considerably increase the size of the image!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because we share the same layers for multiple containers internally, it is true that individually they weight more, but globally the reduction is considerable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate what you mean by internally? Multistage builds?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No multistage, I have several flavours of images, for example the most typical usage is to change the MMG/Python/boost versions (I have builds with different permutations of those lib versions). By splitting those into layers I save a lot of space because the base is common for all of them.