Skip to content

Conversation

@carloslubbers
Copy link
Contributor

@carloslubbers carloslubbers commented Nov 25, 2025

📝 Description
This PR enhances the GeoMechanicsApplication by adding missing process registrations in the dgeosettlement workflow and expanding scheme factory support for additional scheme variants.

This change allows the dgeosettlement workflow to act more as the generic c++ interface for running geo models in Kratos. This will be applied in the cloud runner PoC through GiD.

🆕 Changelog
Added registrations for the following processes:

  • ApplyComponentTableProcess
  • ApplyConstantPhreaticMultiLinePressureProcess
  • ApplyFinalStressesOfPreviousStageToInitialState
  • ApplyInitialUniformStressField
  • CalculateIncrementalMotionProcess
  • CalculateTotalMotionProcess
  • GeoApplyConstantScalarValueProcess
  • SetMultipleMovingLoadsProcess
  • ApplyWriteScalarProcess
  • ApplyCPhiReductionProcess
  • ApplyConstantInterpolateLinePressureProcess
  • SetAbsorbingBoundaryParametersProcess

Added support for 7 scheme variants:

  • BackwardEulerQuasistaticUPwScheme - Backward Euler with U-Pw coupling
  • BackwardEulerQuasistaticPwScheme - Backward Euler with water pressure only
  • NewmarkDynamicUPwScheme - Newmark dynamic analysis
  • NewmarkQuasistaticUPwScheme - Newmark Quasi-Static undamped
  • NewmarkQuasistaticDampedUPwScheme - Newmark Quasi-Static with damping
  • NewmarkQuasistaticPwScheme - Newmark Quasi-Static water pressure only
  • LoadSteppingScheme - Load stepping for static analysis
  • GeoMechanicsStaticScheme - Standard static analysis

@carloslubbers carloslubbers added the GeoMechanics Issues related to the GeoMechanicsApplication label Nov 25, 2025
@carloslubbers carloslubbers force-pushed the geo/add-support-to-factories branch 3 times, most recently from b30a20d to 170fc9d Compare November 25, 2025 09:26
@carloslubbers carloslubbers force-pushed the geo/add-support-to-factories branch 2 times, most recently from 8e3503b to 93b121f Compare December 9, 2025 13:55
@carloslubbers carloslubbers marked this pull request as ready for review December 9, 2025 13:55
@carloslubbers carloslubbers requested a review from a team as a code owner December 9, 2025 13:55
Copy link
Contributor

@WPK4FEM WPK4FEM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Carlos,

First of all the title of this PR is misleading to me. The processes and schemes are present in GeoMechanicsApplication, it is predominantly exposing them to settlement that is changing here.

Settlement and flow are so far deliberately kept to a minimal implementation that only exposes the functionality for a specific type of analysis. This PR is the opposite of that and requires a strategic discussion with PO and team first.

Having that discussion first is the change that I'm requesting. It at least temporarily blocks merging this PR.

Further:
A Quasi-Static scheme does not have inertia terms ( mass ). Getting rayleigh parameters for it is dubious. Creating a NewmarkQuasistaticPwScheme is also unclear to me. Whether an analysis is transient or steady state for, the here only DoF, Pw is not in the naming.

Regards, Wijtze Pieter

@carloslubbers carloslubbers force-pushed the geo/add-support-to-factories branch from 93b121f to eca2b55 Compare December 16, 2025 15:21
@carloslubbers carloslubbers force-pushed the geo/add-support-to-factories branch from eca2b55 to 8864af2 Compare January 5, 2026 14:52
@carloslubbers carloslubbers changed the title [GeoMechanicsApplication] Add missing processes and schemes to GeoMechanicsApplication [GeoMechanicsApplication] Expose missing processes and schemes to GeoMechanicsApplication C++ workflow Jan 8, 2026
@carloslubbers
Copy link
Contributor Author

@WPK4FEM Indeed, whether you want to have a generic c++ interface that can support a multitude of calculations, or a set of locked down tailor-made interfaces is up to the team. This PR mostly exists because it is useful for testing out workflows through GiD.

Regarding the two scheme comments, these are mostly just copied from the existing python logic in geomechanics_U_Pw_solver.py / geomechanics_Pw_solver.py.
The rayleigh parameters are retireved for quasi-static schemes on line 181-187 in the U_Pw solver
The NewmarkQuasistaticPwScheme is created in the Pw_solver on line 127-129

@carloslubbers carloslubbers force-pushed the geo/add-support-to-factories branch from 8864af2 to 090840a Compare January 8, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GeoMechanics Issues related to the GeoMechanicsApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants