-
Notifications
You must be signed in to change notification settings - Fork 277
adding a tensor adaptor to collect node indices from geometries #14094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'd suggest naming it |
matekelemen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, after looking at the tests and reading the PR's title, I understand what yoou're doing, but the class' name is unbelievably misleading.
To me, it was clear as day that GeometryIdsTensorAdaptor fetches the IDs of geometries. But no, it fetches the node IDs of each geometry. Please rename it to something more intuitive.
ConnectivityIdsTrnsorAdaptor? I don t mind changing the name but i am out of ideas...suggestions are welcomd On my side,
|
sunethwarna
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with this, with the minor concerns...
|
@sunethwarna in principle it is ready (with your suggestions and a renamed name) |
sunethwarna
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RiccardoRossi :)
📝 Description
this is a tensor adaptor which collects the node ids from geometries.
🆕 Changelog