Add jacobians test adaptor #14095
Open
Add jacobians test adaptor #14095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunethwarna
reviewed
Jan 7, 2026
Member
sunethwarna
left a comment
sunethwarna
left a comment
There was a problem hiding this comment.
Thanks @RiccardoRossi . Minor comments.
Comment on lines
212
to
220
| if (Datum == GeometriesTensorAdaptor::DatumType::ShapeFunctions) { | ||
| CollectShapeFunctions(pData, rContainer, Method, Shape); | ||
| } else if (Datum == GeometriesTensorAdaptor::DatumType::ShapeFunctionDerivatives) { | ||
| CollectShapeFunctionsDerivatives(pData, rContainer, Method, Shape); | ||
| } else if (Datum == GeometriesTensorAdaptor::DatumType::Jacobians) { | ||
| CollectJacobians(pData, rContainer, Method, Shape); | ||
| } else if (Datum == GeometriesTensorAdaptor::DatumType::IntegrationWeights) { | ||
| CollectIntegrationWeights(pData, rContainer, Method, Shape); | ||
| } |
Member
There was a problem hiding this comment.
Curious why we don't use switch case in here? Wouldn't that be more readable?
Comment on lines
250
to
251
| { | ||
| } |
Member
There was a problem hiding this comment.
I usually add a compatibility check for the rOther.GetContainer() with the current containers in here.
Co-authored-by: Suneth Warnakulasuriya <[email protected]>
Co-authored-by: Suneth Warnakulasuriya <[email protected]>
Member
Author
|
@sunethwarna i corrected your comments (except the use of if case switch which i really do not like) to me this is ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
adding a tentative interface for vectorized functions of geometries. It can be expanded to other methods in the geometry