[Core] Fix JSON output formatting for resultant vector variables #14101
+27
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loumalouomega
added
Kratos Core
Python
Testing
Hotfix
FastPR
avdg81
reviewed
Jan 8, 2026
Contributor
avdg81
left a comment
avdg81
left a comment
There was a problem hiding this comment.
Hi @loumalouomega,
Thanks a lot for correcting the behavior when asking for "resultant" vectors in case of JSON output. I'm glad that it required relatively little changes to improve the behavior. I have a few minor suggestions as well as some questions. Hope this helps.
Co-authored-by: Anne van de Graaf <[email protected]>
avdg81
approved these changes
Jan 8, 2026
Contributor
avdg81
left a comment
avdg81
left a comment
There was a problem hiding this comment.
Thanks for processing all of the review suggestions. I feel this PR is ready to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Fixes after #14076 so the resultant vector is correct.
🆕 Changelog