158 update requirements and installation procedure #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 18, 2025 15:48
added 7 commits
September 21, 2025 23:02
MattScicluna
approved these changes
Sep 22, 2025
Contributor
MattScicluna
left a comment
MattScicluna
left a comment
There was a problem hiding this comment.
I think you can merge as-is, but left some comments for your consideration.
| ] | ||
| license = {text = "GNU General Public License Version 2"} | ||
| readme = "README.md" | ||
| requires-python = ">=3.9" |
Contributor
There was a problem hiding this comment.
I thought this works for python >=3.8 ?
Contributor
There was a problem hiding this comment.
We should make sure this doesnt break the phate tutorial notebook
Contributor
There was a problem hiding this comment.
do we not need to test in python 3.11+ ?
Contributor
Author
|
I have removed 3.8 since it is already in end-of-life. Added tests for the other two's. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.