Skip to content

Add back sgd mds #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bjoaofelipe merged 4 commits into from
Oct 21, 2025
Merged

Add back sgd mds #163

bjoaofelipe merged 4 commits into from
Oct 21, 2025

Conversation

@MattScicluna
Copy link
Contributor

@MattScicluna MattScicluna commented Oct 20, 2025

No description provided.

@coveralls
Copy link

coveralls commented Oct 21, 2025

Pull Request Test Coverage Report for Build 18685928124

Details

  • 59 of 78 (75.64%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 71.351%
Changes Missing Coverage Covered Lines Changed/Added Lines %
Python/phate/mds.py 5 8 62.5%
Python/phate/phate.py 3 6 50.0%
Python/phate/sgd_mds.py 50 63 79.37%
Files with Coverage Reduction New Missed Lines %
Python/phate/mds.py 2 70.59%
Totals Coverage Status
Change from base Build 18685601908: 0.09%
Covered Lines: 523
Relevant Lines: 733
💛 - Coveralls

3 similar comments
@coveralls
Copy link

coveralls commented Oct 21, 2025

Pull Request Test Coverage Report for Build 18685928124

Details

  • 59 of 78 (75.64%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 71.351%
Changes Missing Coverage Covered Lines Changed/Added Lines %
Python/phate/mds.py 5 8 62.5%
Python/phate/phate.py 3 6 50.0%
Python/phate/sgd_mds.py 50 63 79.37%
Files with Coverage Reduction New Missed Lines %
Python/phate/mds.py 2 70.59%
Totals Coverage Status
Change from base Build 18685601908: 0.09%
Covered Lines: 523
Relevant Lines: 733
💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 21, 2025

Pull Request Test Coverage Report for Build 18685928124

Details

  • 59 of 78 (75.64%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 71.351%
Changes Missing Coverage Covered Lines Changed/Added Lines %
Python/phate/mds.py 5 8 62.5%
Python/phate/phate.py 3 6 50.0%
Python/phate/sgd_mds.py 50 63 79.37%
Files with Coverage Reduction New Missed Lines %
Python/phate/mds.py 2 70.59%
Totals Coverage Status
Change from base Build 18685601908: 0.09%
Covered Lines: 523
Relevant Lines: 733
💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 21, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 18685928124

Details

  • 59 of 78 (75.64%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 71.351%
Changes Missing Coverage Covered Lines Changed/Added Lines %
Python/phate/mds.py 5 8 62.5%
Python/phate/phate.py 3 6 50.0%
Python/phate/sgd_mds.py 50 63 79.37%
Files with Coverage Reduction New Missed Lines %
Python/phate/mds.py 2 70.59%
Totals Coverage Status
Change from base Build 18685601908: 0.09%
Covered Lines: 523
Relevant Lines: 733
💛 - Coveralls

@bjoaofelipe bjoaofelipe merged commit e5f031a into KrishnaswamyLab:main Oct 21, 2025
5 of 6 checks passed
@MattScicluna MattScicluna mentioned this pull request Oct 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjoaofelipe bjoaofelipe Awaiting requested review from bjoaofelipe

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MattScicluna @coveralls @bjoaofelipe