experimental changes #135
Open
experimental changes #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying interface with
|
| Latest commit: |
925e68a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://59fe11f5.interface-ctb.pages.dev |
| Branch Preview URL: | https://biglad7528-limitorderlist-op.interface-ctb.pages.dev |
abhi-apple
reviewed
May 31, 2025
| function LimitOrderList() { | ||
| const { account } = useActiveWeb3React() | ||
| const { positions, fundingBalance, minBalance } = useV3Positions(account) | ||
| type Props = { |
There was a problem hiding this comment.
The use of explicit Props typing ensures consumers of LimitOrderList know exactly what is expected.
Slightly might increases complexity for parent components and requires careful prop management.
| } | ||
|
|
||
| export function SwitchLocaleLink() { | ||
| const SwitchLocaleLink = memo(() => { |
There was a problem hiding this comment.
Refactored the SwitchLocaleLink component to use React.memo for performance optimization. This is a good move, as it will help prevent unnecessary re-renders if the props remain unchanged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental branch, solely for the oppose of testing, PLEASE DO NOT MERGE