WorldObject Repository Layer #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge v1.1.0 to main
merge 1.1.1 to main
merge v1.1.2
…existing architecture
Owner
|
Sounds awesome! Can you change the PR to merge into develop? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all of a worlds legend data has to be loaded into memory while using the application. For larger worlds this can take up a substantial amount of a computers available memory.
Since the application is acting as a standalone web app it should be possible to transition to pulling the necessary data on-demand without being too noticeable to users.
Since I'm still getting familiar with the source code I thought I'd start out by transitioning the bulk of the controllers to use a repository layer while retaining the original core logic.
In the future, the exact implementation details of the repositories can be updated without too much hassle which will make a change to a new data management system much easier.