Move no prediction #242
Merged
Move no prediction #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This is failing our ruff format and linting checks @SkepticRaven please run |
gbeane
approved these changes
Dec 1, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the handling of "no prediction" cases by moving the logic from post-processing locations (UI classification thread and CLI) into the classifier's predict and predict_proba methods. This centralizes the responsibility of blanking predictions for invalid poses into the classifier itself.
Key changes:
- Updated
predictandpredict_probamethods to accept optionalframe_indexesparameter and handle invalid frames internally - Removed
frame_indexestracking and filtering logic from UI classification thread and CLI classification script - Simplified
save_predictionsmethod by removing frame index-based filtering
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/jabs/classifier/classifier.py | Added frame_indexes parameter to predict and predict_proba methods; added logic to insert -1 for predictions and 0 for probabilities at invalid frame positions |
| src/jabs/ui/classification_thread.py | Removed frame_indexes tracking; passed frame_indexes to classifier methods instead of filtering afterward |
| src/jabs/ui/central_widget.py | Removed _frame_indexes from classification thread output handling |
| src/jabs/scripts/classify.py | Removed frame-based filtering logic; passed frame_indexes to classifier methods; simplified result copying |
| src/jabs/project/project.py | Removed frame_indexes parameter and related filtering logic from save_predictions method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Resolved conflicts in classifier.py by combining: - frame_indexes parameter support from move-no-prediction branch - CatBoost classifier support from main branch Both features are now integrated in predict() and predict_proba() methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the location of where "no prediction" is applied.
Handling of removing predictions when poses are invalid prior to these changes was applied in 2 separate locations:
Blanking predictions after these changes is now owned by the classifier's
predictandpredict_probamethods.