Remove static list of names and URIs from require_errdefer_deinit #48#117
Merged
KurtWagner merged 6 commits into0.15.xfrom Sep 18, 2025
Merged
Remove static list of names and URIs from require_errdefer_deinit #48#117KurtWagner merged 6 commits into0.15.xfrom
require_errdefer_deinit #48#117KurtWagner merged 6 commits into0.15.xfrom
Conversation
KurtWagner
changed the title
require_errdefer_deinitrequire_errdefer_deinit #48
KurtWagner
added a commit
that referenced
this pull request
Sep 18, 2025
… (#117) It now checks whether the type has a `deinit` call. It still tries to limit noise by only looking at declarations to `.empty`, `.init`, `initCapacity(..)` or `init(..)` without parameters that look like arenas or fixed buffers. I'm unsure about this.
KurtWagner
added a commit
that referenced
this pull request
Sep 18, 2025
… (#117) It now checks whether the type has a `deinit` call. It still tries to limit noise by only looking at declarations to `.empty`, `.init`, `initCapacity(..)` or `init(..)` without parameters that look like arenas or fixed buffers. I'm unsure about this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It now checks whether the type has a
deinitcall.It still tries to limit noise by only looking at declarations to
.empty,.init,initCapacity(..)orinit(..)without parameters that look like arenas or fixed buffers. I'm unsure about this.