Refactor to pass lint document by pointer#118
Merged
KurtWagner merged 8 commits into0.15.xfrom Sep 22, 2025
Merged
Conversation
KurtWagner
added a commit
that referenced
this pull request
Sep 22, 2025
) This avoids confusion around shallow copies and mutability as it was mutating what the pointers in the shallow copies were pointing to. This is breaking in that run accepts a pointer and context is re-introduced. Before: ```zig fn ( self: LintRule, doc: session.LintDocument, gpa: std.mem.Allocator, options: RunOptions, ) error{OutOfMemory}!?results.LintResult ``` After: ```zig fn ( self: LintRule, context: *session.LintContext, doc: *const session.LintDocument, gpa: std.mem.Allocator, options: RunOptions, ) error{OutOfMemory}!?results.LintResult ```
KurtWagner
added a commit
that referenced
this pull request
Sep 22, 2025
) This avoids confusion around shallow copies and mutability as it was mutating what the pointers in the shallow copies were pointing to. This is breaking in that run accepts a pointer and context is re-introduced. Before: ```zig fn ( self: LintRule, doc: session.LintDocument, gpa: std.mem.Allocator, options: RunOptions, ) error{OutOfMemory}!?results.LintResult ``` After: ```zig fn ( self: LintRule, context: *session.LintContext, doc: *const session.LintDocument, gpa: std.mem.Allocator, options: RunOptions, ) error{OutOfMemory}!?results.LintResult ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids confusion around shallow copies and mutability as it was mutating what the pointers in the shallow copies were pointing to.
This is breaking in that run accepts a pointer and context is re-introduced.
Before:
After: