Skip to content

Comments

Fix the build with the latest zig master#140

Merged
KurtWagner merged 3 commits intoKurtWagner:masterfrom
theoparis:master
Feb 7, 2026
Merged

Fix the build with the latest zig master#140
KurtWagner merged 3 commits intoKurtWagner:masterfrom
theoparis:master

Conversation

@theoparis
Copy link
Contributor

Depends on zigtools/zls#2594

@KurtWagner
Copy link
Owner

Thanks! I'll take a look once ZLS is updated

@theoparis
Copy link
Contributor Author

theoparis commented Feb 7, 2026

zig build lint currently seems to pick up integration-tests/zig-pkg (which contains dependencies as of https://codeberg.org/ziglang/zig/pulls/31121) as files to be linted 🤔

@KurtWagner
Copy link
Owner

KurtWagner commented Feb 7, 2026

Oh https://codeberg.org/ziglang/zig/pulls/31121 is a nice change (I'm one of those people who vendors dependencies in projects).

I'm thinking we'd want to always exclude linting zig-pkg/ files so files.isLintableFilePath would need to be updated to also exclude zig-pkg/ files.

Copy link
Owner

@KurtWagner KurtWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve and merge this in as it's a step forward and we can fix other master breaking changes in followups. Thanks for your contribution

@KurtWagner KurtWagner marked this pull request as ready for review February 7, 2026 18:18
@KurtWagner KurtWagner merged commit dca9ab8 into KurtWagner:master Feb 7, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants