Skip to content

feat: set default ordered kinds as public #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liu-hm19 merged 1 commit into from
Nov 29, 2024
+4 −4
Merged

feat: set default ordered kinds as public #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/module/generator/ordered_resources.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import (

type resource v1.Resource

// defaultOrderedKinds provides the default order of Kubernetes resource kinds.
var defaultOrderedKinds = []string{
// DefaultOrderedKinds provides the default order of Kubernetes resource kinds.
var DefaultOrderedKinds = []string{
"Namespace",
"ResourceQuota",
"StorageClass",
Expand Down Expand Up @@ -42,7 +42,7 @@ var defaultOrderedKinds = []string{
// in a specified order.
func OrderedResources(ctx context.Context, resources v1.Resources, orderedKinds []string) (v1.Resources, error) {
if len(orderedKinds) == 0 {
orderedKinds = defaultOrderedKinds
orderedKinds = DefaultOrderedKinds
}

if len(resources) == 0 {
Expand Down
2 changes: 1 addition & 1 deletion pkg/module/generator/ordered_resources_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ func TestFindDependKinds(t *testing.T) {
"PersistentVolume",
"PersistentVolumeClaim",
}
actual := r.findDependKinds(defaultOrderedKinds)
actual := r.findDependKinds(DefaultOrderedKinds)

assert.Equal(t, expected, actual)
}
Expand Down