Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 53 additions & 7 deletions pkg/log/hclog.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"fmt"
"path/filepath"
"strconv"

"github.com/hashicorp/go-hclog"
"google.golang.org/grpc/metadata"
Expand All @@ -13,8 +14,11 @@ import (
)

const (
KusionModuleName = "kusion_module_name"
KusionTraceID = "kusion_trace_id"
KusionModuleName = "kusion_module_name"
KusionTraceID = "kusion_trace_id"
KusionModuleLogMaxSize = "kusion_module_log_max_size"
KusionModuleLogMaxBackups = "kusion_module_log_max_backups"
KusionModuleLogMaxAge = "kusion_module_log_max_age"
)

func GetModuleLogger(ctx context.Context) hclog.Logger {
Expand All @@ -26,12 +30,15 @@ func GetModuleLogger(ctx context.Context) hclog.Logger {

kusionDataDir, _ := kfile.KusionDataFolder()
logFile := filepath.Join(kusionDataDir, Folder, "modules", moduleName, fmt.Sprintf("%s.log", moduleName))
maxSize, maxBackups, maxAge := getRotationConfigs(ctx)

lumberjackLogger := &lumberjack.Logger{
Filename: logFile,
MaxSize: 10,
Compress: false,
LocalTime: true,
MaxAge: 28,
Filename: logFile,
MaxSize: maxSize,
MaxBackups: maxBackups,
MaxAge: maxAge,
Compress: false,
LocalTime: true,
}

return hclog.New(&hclog.LoggerOptions{
Expand All @@ -56,3 +63,42 @@ func getModuleName(ctx context.Context) string {
}
return names[0]
}

func getRotationConfigs(ctx context.Context) (logMaxSize, logMaxBackups, logMaxAge int) {
var err error

logMaxSizeStrs := metadata.ValueFromIncomingContext(ctx, KusionModuleLogMaxSize)
if len(logMaxSizeStrs) == 0 {
// Set the default max size of kusion module logger to 10MB.
logMaxSize = 10
} else {
logMaxSize, err = strconv.Atoi(logMaxSizeStrs[0])
if err != nil {
logMaxSize = 10
}
}

logMaxBackupStrs := metadata.ValueFromIncomingContext(ctx, KusionModuleLogMaxBackups)
if len(logMaxBackupStrs) == 0 {
// Set the default max backups of kusion module logger to 10.
logMaxBackups = 10
} else {
logMaxBackups, err = strconv.Atoi(logMaxBackupStrs[0])
if err != nil {
logMaxBackups = 10
}
}

logMaxAgeStrs := metadata.ValueFromIncomingContext(ctx, KusionModuleLogMaxAge)
if len(logMaxAgeStrs) == 0 {
// Set the default max age of kusion module logger to 28 days.
logMaxAge = 28
} else {
logMaxAge, err = strconv.Atoi(logMaxAgeStrs[0])
if err != nil {
logMaxAge = 28
}
}

return
}
62 changes: 62 additions & 0 deletions pkg/log/hclog_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,65 @@ func TestGetModuleName(t *testing.T) {
})
}
}

func TestGetRotationConfigs(t *testing.T) {
tests := []struct {
name string
input map[string]string
wantedMaxSize int
wantedMaxBackups int
wantedMaxAge int
}{
{
name: "empty input",
input: nil,
wantedMaxSize: 10,
wantedMaxBackups: 10,
wantedMaxAge: 28,
},
{
name: "empty input values",
input: map[string]string{
KusionModuleLogMaxSize: "",
KusionModuleLogMaxBackups: "",
KusionModuleLogMaxAge: "",
},
wantedMaxSize: 10,
wantedMaxBackups: 10,
wantedMaxAge: 28,
},
{
name: "invalid input values",
input: map[string]string{
KusionModuleLogMaxSize: "?",
KusionModuleLogMaxBackups: "?",
KusionModuleLogMaxAge: "?",
},
wantedMaxSize: 10,
wantedMaxBackups: 10,
wantedMaxAge: 28,
},
{
name: "customized valid input values",
input: map[string]string{
KusionModuleLogMaxSize: "100",
KusionModuleLogMaxBackups: "100",
KusionModuleLogMaxAge: "100",
},
wantedMaxSize: 100,
wantedMaxBackups: 100,
wantedMaxAge: 100,
},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
ctx := metadata.NewIncomingContext(context.Background(), metadata.New(tt.input))
if gotMaxSize, gotMaxBackups, gotMaxAge := getRotationConfigs(ctx); gotMaxSize != tt.wantedMaxSize ||
gotMaxBackups != tt.wantedMaxBackups || gotMaxAge != tt.wantedMaxAge {
t.Errorf("getRotationConfigs() = %d, %d, %d want %d, %d, %d", gotMaxSize, gotMaxBackups, gotMaxAge,
tt.wantedMaxSize, tt.wantedMaxBackups, tt.wantedMaxAge)
}
})
}
}
Loading