feat: support path-style of bucket for s3 storage backend#1189
Merged
liu-hm19 merged 1 commit intoKusionStack:mainfrom Jun 27, 2024
hoangndst:s3-path-style
Merged
feat: support path-style of bucket for s3 storage backend#1189liu-hm19 merged 1 commit intoKusionStack:mainfrom hoangndst:s3-path-style
liu-hm19 merged 1 commit intoKusionStack:mainfrom
hoangndst:s3-path-style
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Member
Author
|
I have read the CLA Document and I hereby sign the CLA |
Pull Request Test Coverage Report for Build 9683712546Details
💛 - Coveralls |
Contributor
|
@hoangndst Thank you very much for submitting this pull request! This PR looks good to me, but it didn't pass the Commit Lint check. We would appreciate it if you could update the commit message in the following format and push it again. # reset the commit
git reset --soft HEAD^
# update the commit message
git commit -m "feat: force path-style"
# force push to the remote branch
git push [remote-repo] s3-path-style:s3-path-style -f |
liu-hm19
approved these changes
Jun 27, 2024
Contributor
liu-hm19
left a comment
There was a problem hiding this comment.
lgtm, thanks a lot for submitting this pull request! Please update the commit message and push the branch again to pass the Commit Lint check.
Member
|
@hoangndst Thank you very much for your contribution! Welcome to the community! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Currently, the endpoint of S3 is only in Virtual-hosted–style: https://bucket_name.s3.example.com/. The error will occur if in the case of S3 Storage Server only supports Certificate for Path-Style like https://s3.example.com/bucket_name/
Which issue(s) this PR fixes:
Fixes #1178
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., design docs, usage docs, etc.: