fix: Prevent DiscordRPC crash when text exceeds 128 bytes (#38)#39
Open
kriYamiHikari wants to merge 9 commits intoKxnrl:masterfrom
Open
fix: Prevent DiscordRPC crash when text exceeds 128 bytes (#38)#39kriYamiHikari wants to merge 9 commits intoKxnrl:masterfrom
kriYamiHikari wants to merge 9 commits intoKxnrl:masterfrom
Conversation
kriYamiHikari
commented
Dec 15, 2024
kriYamiHikari
commented
- Added string truncation to handle text overflow and prevent crashes.
- Fixed a bug where text longer than 128 bytes would cause the program to crash or behave unexpectedly.
- Ensured that all text sent to DiscordRPC is truncated to the 128-byte limit.
- Added string truncation to handle text overflow and prevent crashes. - Fixed a bug where text longer than 128 bytes would cause the program to crash or behave unexpectedly. - Ensured that all text sent to DiscordRPC is truncated to the 128-byte limit.
- Improved memory access performance by introducing caching mechanisms to avoid redundant queries - Added debounce logic for state updates to prevent potential RPC API throttling and outdated music info display (Kxnrl#44) TODO: Refactor
- Extracted core RPC update logic into a dedicated `RpcManager` class - Simplified the flow in `Program.cs`
- Added caching mechanism for NetEase Cloud Music to reduce memory pressure - Modified info display to show a small pause icon when playback is stopped instead of clearing the Presence
|
你好，可以让discord成员列表中的 “Listening to Netease Music"字样 变成 ”Listening to [歌曲名]“吗？ 
|
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.